Skip to content

Commit 9f9ee47

Browse files
committed
docs fixes, typo fix depr solveFactorParameteric
1 parent 85cf101 commit 9f9ee47

File tree

8 files changed

+11
-9
lines changed

8 files changed

+11
-9
lines changed

NEWS.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ The list below highlights breaking changes according to normal semver workflow -
2424
- Restore `DifferentialEquation.jl` factor `DERelative` functionality and tests that were suppressed in a previous upgrade (#1774, #1777).
2525
- Restore previously suppressed tests (#1781, #1721, #1780)
2626
- Improve DERelative factor on-manifold operations (#1775, #1802, #1803).
27+
- Fixed a typo via deprecation, `solveFactorParametric` replaces `solveFactorParameteric`.
2728

2829
# Changes in v0.34
2930

@@ -110,7 +111,7 @@ The list below highlights breaking changes according to normal semver workflow -
110111
- Upstream `calcHelix_T` canonical generator utility from RoME.jl.
111112
- Deserialization of factors with DFG needs new API and change of solverData and CCW type in factor.
112113
- Deprecate use of `getParametricMeasurement` and use `getMeasurementParametric` instead, and add `<:AbstractManifold` to API.
113-
- Deprecate use of `solveBinaryFactorParameteric`, instead use `solveFactorParameteric`.
114+
- Deprecate use of `solveBinaryFactorParameteric`, instead use `solveFactorParametric`.
114115
- Deprecating `approxConvBinary`, use `approxConvBelief` instead.
115116
- Removing obsolete `approxConvCircular`, use `approxConvBelief` instead.
116117
- `getSample` should return a single sample and no longer takes the N(number of samples) parameter.

src/Deprecated.jl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,7 @@ end
123123
## Deprecate code below before v0.37
124124
##==============================================================================
125125

126+
@deprecate solveFactorParameteric(w...;kw...) solveFactorParametric(w...;kw...)
126127

127128
##==============================================================================
128129
## Deprecate code below before v0.36

src/ExportAPI.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -344,7 +344,7 @@ export approxDeconvBelief
344344
export cont2disc
345345
export rebaseFactorVariable!
346346
export accumulateFactorMeans
347-
export solveFactorParameteric
347+
export solveFactorParametric
348348

349349
export repeatCSMStep!
350350
export attachCSM!

src/parametric/services/ConsolidateParametricRelatives.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ DevNotes
1818
1919
Related: [`getMeasurementParametric`](@ref), [`approxConvBelief`](@ref), [`MutablePose2Pose2Gaussian`](@ref)
2020
"""
21-
function solveFactorParameteric(
21+
function solveFactorParametric(
2222
dfg::AbstractDFG,
2323
fct::DFGFactor,
2424
# currval::P1,

src/parametric/services/ParametricUtils.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ Notes
5252
- Originally written just for Lie Groups to support legacy, but future needs may well alter the design.
5353
- Original design driven by parametric solve and dead reckon tethering.
5454
55-
See also: [`accumulateFactorMeans`](@ref), [`solveFactorParameteric`](@ref)
55+
See also: [`accumulateFactorMeans`](@ref), [`solveFactorParametric`](@ref)
5656
"""
5757
function getMeasurementParametric end
5858

@@ -648,7 +648,7 @@ DevNotes
648648
- WIP
649649
- Relates to: https://github.com/JuliaRobotics/IncrementalInference.jl/issues/466#issuecomment-562556953
650650
- Consolidation
651-
- Definitely with [`solveFactorParameteric`](@ref)
651+
- Definitely with [`solveFactorParametric`](@ref)
652652
- Maybe with [`solveGraphParametric`](@ref)
653653
- https://github.com/JuliaRobotics/IncrementalInference.jl/pull/1588#issuecomment-1210406683
654654
"""

src/services/EvalFactor.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -620,7 +620,7 @@ B = _evalFactorTemporary!(EuclidDistance, (ContinuousScalar, ContinuousScalar),
620620
# should return `B = 10`
621621
```
622622
623-
See also: [`calcFactorResidual`](@ref), [`testFactorResidualBinary`](@ref), [`solveFactorParameteric`](@ref), [`approxConvBelief`](@ref)
623+
See also: [`calcFactorResidual`](@ref), [`testFactorResidualBinary`](@ref), [`solveFactorParametric`](@ref), [`approxConvBelief`](@ref)
624624
"""
625625
function _evalFactorTemporary!(
626626
fct::AbstractFactor,

src/services/SolverUtilities.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ Notes
203203
- This function does not add new variables or factors to `fg`, user must do that themselves after.
204204
- Useful to use in combination with `setPPE!` on new variable.
205205
- At time of writing `accumulateFactorMeans` could only incorporate priors or binary relative factors.
206-
- internal info, see [`solveFactorParameteric`](@ref),
206+
- internal info, see [`solveFactorParametric`](@ref),
207207
- This means at time of writing `factor` must be a binary factor.
208208
- Tip, if simulations are inducing odometry bias, think of using two factors from caller (e.g. simPerfect and simBias).
209209

src/services/TetherUtils.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ DevNotes
114114
115115
Related:
116116
117-
[`approxConvBelief`](@ref), [`solveFactorParameteric`](@ref), `RoME.MutablePose2Pose2Gaussian`
117+
[`approxConvBelief`](@ref), [`solveFactorParametric`](@ref), `RoME.MutablePose2Pose2Gaussian`
118118
"""
119119
function accumulateFactorMeans(
120120
dfg::AbstractDFG,
@@ -150,7 +150,7 @@ function accumulateFactorMeans(
150150
# first find direction of solve
151151
vars = getVariableOrder(fct)
152152
trgsym = setdiff(vars, [srcsym])[1]
153-
val = solveFactorParameteric(dfg, fct, [srcsym => val;], trgsym; solveKey)
153+
val = solveFactorParametric(dfg, fct, [srcsym => val;], trgsym; solveKey)
154154
srcsym = trgsym
155155
end
156156

0 commit comments

Comments
 (0)