Skip to content

Commit bb851a7

Browse files
committed
bug fix, approxConv chain tfg params
1 parent c5b671e commit bb851a7

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

src/services/ApproxConv.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ function approxConvBelief(
7979
measurement::AbstractVector = Tuple[];
8080
solveKey::Symbol = :default,
8181
N::Int = length(measurement),
82-
tfg::AbstractDFG = initfg(),
82+
tfg::AbstractDFG = LocalDFG(;solverParams=getSolverParams(dfg)),
8383
setPPEmethod::Union{Nothing, Type{<:AbstractPointParametricEst}} = nothing,
8484
setPPE::Bool = setPPEmethod !== nothing,
8585
path::AbstractVector{Symbol} = Symbol[],

test/testApproxConv.jl

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,4 +97,14 @@ approxConvBelief(fg, :x0f1, :x0)
9797
##
9898
end
9999

100+
101+
@testset "Test all approxConv versions have same parameter behavior" begin
102+
##
103+
104+
@warn("TODO .inflateCycles ignored in chain version of approxConv(fg, :x0, :x1)!")
105+
@test_broken false
106+
107+
##
108+
end
109+
100110
#

0 commit comments

Comments
 (0)