Skip to content

Commit cde04e6

Browse files
committed
update comment and trigger tests
1 parent c272ba9 commit cde04e6

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/FactorGraph.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -680,10 +680,10 @@ function prepgenericconvolution(Xi::Vector{<:DFGVariable},
680680
gradients = nothing
681681
# prepare new cached gradient lambdas (attempt)
682682
try
683-
# this try block definitely fails on deserialization, due to empty DFGVariable[] vector here:
684683
# https://github.com/JuliaRobotics/IncrementalInference.jl/blob/db7ff84225cc848c325e57b5fb9d0d85cb6c79b8/src/DispatchPackedConversions.jl#L46
685684
# also https://github.com/JuliaRobotics/DistributedFactorGraphs.jl/issues/590#issuecomment-891450762
686-
if (!_blockRecursion) && usrfnc isa AbstractRelative
685+
# FIXME, suppressing nested gradient propagation on GenericMarginals for the time being, see #1010
686+
if (!_blockRecursion) && usrfnc isa AbstractRelative && !(usrfnc isa GenericMarginal)
687687
# take first value from each measurement-tuple-element
688688
measurement_ = map(x->x[1], meas_single)
689689
# compensate if no info available during deserialization

0 commit comments

Comments
 (0)