Add build_cpu_target global to opt-in to generic CPU at precompile-time

We already support this dynamically, but for some reason it wasn't
possible to get this configuration at precompilation time. Also adds
a "freeze_cpu_target" preference to enable this behavior by default.

Author: topolarity

src/HostCPUFeatures.jl

@@ -14,6 +14,25 @@ using BitTwiddlingConvenienceFunctions: prevpow2, nextpow2, intlog2
 export has_feature, fma_fast, pick_vector_width, pick_vector_width_shift, register_count,
   register_size, simd_integer_register_size
 
+_cpu_target = if @has_preference("cpu_target")
+  @load_preference("cpu_target")
+else
+  Base.unsafe_string(Base.JLOptions().cpu_target)
+end
+
+const build_cpu_target = if occursin("native", _cpu_target)
+  "native" # 'native' takes priority if provided
+else
+  split(_cpu_target, ";")[1]
+end
+
+# If true, this will opt-in to "freeze" an under-approximation of the CPU features at precompile-
+# time based on the CPU target.
+#
+# This is only done by default if "native" was excluded from the CPU target (or via a preference).
+const freeze_cpu_target =
+  @load_preference("freeze_cpu_target", false) || build_cpu_target != "native"
+
 function get_cpu_name()::String
   if isdefined(Sys, :CPU_NAME)
     Sys.CPU_NAME
@@ -46,12 +65,29 @@ end
 const BASELINE_CPU_NAME = get_cpu_name()
 const allow_eval = @load_preference("allow_runtime_invalidation", false)
 
+function make_generic(target)
+  target == "native" && return false
+  if Sys.ARCH === :x86_64 || Sys.ARCH === :i686
+    make_generic_x86(target)
+    return true
+  else
+    return false
+  end
+end
+
+make_generic(build_cpu_target)
+
 function __init__()
   ccall(:jl_generating_output, Cint, ()) == 1 && return
-  if Sys.ARCH === :x86_64 || Sys.ARCH === :i686
-    target = Base.unsafe_string(Base.JLOptions().cpu_target)
-    if !occursin("native",  target)
-      make_generic(target)
+  freeze_cpu_target && return # CPU info fixed at precompile-time
+
+  runtime_target = Base.unsafe_string(Base.JLOptions().cpu_target)
+  if !occursin("native", runtime_target)
+    # The CPU target included "native" at pre-compile time, but at runtime it did not!
+    #
+    # Fixing this discepancy will invalidate the whole world (so it should probably
+    # throw an error), but we do it anyway for backwards-compatibility.
+    if make_generic(runtime_target)
       return nothing
     end
   end

src/cpu_info.jl

@@ -39,9 +39,10 @@ function set_features!()
   end
   Libc.free(features_cstring)
 end
-set_features!()
-
 
+if build_cpu_target == "native"
+    set_features!()
+end
 
 function reset_features!()
     features, features_cstring = feature_string()
@@ -70,5 +71,8 @@ function redefine_cpu_name()
       @warn "Runtime invalidation was disabled, but the CPU info is out-of-date.\nWill continue with incorrect CPU name (from build time)."
     end
 end
-cpu = QuoteNode(Symbol(get_cpu_name()))
-@eval cpu_name() = Val{$cpu}()
+
+let _cpu = QuoteNode(Symbol(build_cpu_target == "native" ?
+			    get_cpu_name() : build_cpu_target))
+   @eval cpu_name() = Val{$_cpu}()
+end

src/cpu_info_aarch64.jl

@@ -28,7 +28,7 @@ function _set_sve_vector_width!(bytes = _dynamic_register_size())
 end
 
 
-if _has_aarch64_sve()# && !(Bool(has_feature(Val(:aarch64_sve))))
+if build_cpu_target == "native" && _has_aarch64_sve()# && !(Bool(has_feature(Val(:aarch64_sve))))
     has_feature(::Val{:aarch64_sve_cpuid}) = True()
     _set_sve_vector_width!()
 else

src/cpu_info_x86.jl

@@ -51,7 +51,7 @@ end
   end
 end
 
-function make_generic(target)
+function make_generic_x86(target)
   if occursin("tigerlake", target) || occursin("znver4", target) || occursin("sapphirerapids", target)
     # most feature-complete architectures we use
     setfeaturetrue(:x86_64_avx512ifma)