Reenable byte-store-as-bits test on non-AVX2 LLVM 6 architectures, and see if it passes.

Author: chriselrod

Project.toml

@@ -13,10 +13,10 @@ VectorizationBase = "3d5dd08c-fd9d-11e8-17fa-ed2836048c2f"
 
 [compat]
 OffsetArrays = "1"
-SIMDPirates = "0.7.12"
+SIMDPirates = "0.7.13"
 SLEEFPirates = "0.4.4"
 UnPack = "0"
-VectorizationBase = "0.10.3"
+VectorizationBase = "0.10.4"
 julia = "1.1"
 
 [extras]

src/determinestrategy.jl

@@ -132,7 +132,7 @@ function evaluate_cost_unroll(
             loopdependencies(op) ⊆ nested_loop_syms || continue
             # hasintersection(reduceddependencies(op), nested_loop_syms) && return Inf
             rd = reduceddependencies(op)
-            hasintersection(rd, nested_loop_syms[1:end-length(rd)]) && return Inf
+            hasintersection(rd, @view(nested_loop_syms[1:end-length(rd)])) && return Inf
             included_vars[id] = true
             # @show op first(cost(op, vectorized, Wshift, size_T)), iter
             total_cost += iter * first(cost(ls, op, vectorized, Wshift, size_T))
@@ -576,7 +576,7 @@ function evaluate_cost_tile(
             # # @show nested_loop_syms
             # # @show reduceddependencies(op)
             rd = reduceddependencies(op)
-            hasintersection(rd, nested_loop_syms[1:end-length(rd)]) && return 0,0,Inf
+            hasintersection(rd, @view(nested_loop_syms[1:end-length(rd)])) && return 0,0,Inf
             included_vars[id] = true
             unrolledtiled[1,id] = unrolled ∈ loopdependencies(op)
             unrolledtiled[2,id] = tiled ∈ loopdependencies(op)

test/ifelsemasks.jl

@@ -404,20 +404,22 @@ T = Float32
     @test t ≈ Bernoulli_logitavx(bit, a)
     @test t ≈ Bernoulli_logit_avx(bit, a)
 
-    if LoopVectorization.VectorizationBase.AVX2 || Base.libllvm_version ≥ v"8" #FIXME Why doesn't this work on Travis Ivy Bridge Julia 1.1?
-        ai = [rand(Bool) for _ in 1:71];
-        bi = [rand(Bool) for _ in 1:71];
+    ai = [rand(Bool) for _ in 1:71];
+    bi = [rand(Bool) for _ in 1:71];
+    # if LoopVectorization.VectorizationBase.AVX2 || Base.libllvm_version ≥ v"8" #FIXME Why doesn't this work on Travis Ivy Bridge Julia 1.1?
         @test (ai .& bi) == (@avx ai .& bi)
         @test (ai .| bi) == (@avx ai .| bi)
         @test (ai .⊻ bi) == (@avx ai .⊻ bi)
-    else
-        @test_broken (ai .& bi) == (@avx ai .& bi)
-        @test_broken (ai .| bi) == (@avx ai .| bi)
-        @test_broken (ai .⊻ bi) == (@avx ai .⊻ bi)
-    end
+    # else
+    #     @test_broken (ai .& bi) == (@avx ai .& bi)
+    #     @test_broken (ai .| bi) == (@avx ai .| bi)
+    #     @test_broken (ai .⊻ bi) == (@avx ai .⊻ bi)
+    #     @test_broken (Ai .& bi) == (@avx Ai .& bi)
+    #     @test_broken (ai .| Bi) == (@avx ai .| Bi)
+    #     @test_broken (Ai .⊻ Bi) == (@avx Ai .⊻ Bi)
+    # end
     a = bitrand(127); b = bitrand(127);
     @test (a .& b) == (@avx a .& b)
     @test (a .| b) == (@avx a .| b)
     @test (a .⊻ b) == (@avx a .⊻ b)
-    
 end