Skip to content

Commit 09cdd94

Browse files
committed
Add test for printing a store, and also to confirm presence of reduce_to_add instruction when reducing zeros.
1 parent 4f84081 commit 09cdd94

File tree

2 files changed

+21
-5
lines changed

2 files changed

+21
-5
lines changed

src/operations.jl

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,11 @@ Base.convert(::Type{ArrayReference}, ref::ArrayReferenceMeta) = ref.ref
3535
Base.:(==)(x::ArrayReference, y::ArrayReference) = isequal(x, y)
3636
Base.:(==)(x::ArrayReferenceMeta, y::ArrayReferenceMeta) = isequal(x.ref, y.ref) && x.ptr === y.ptr
3737

38-
39-
Base.:(==)(x::ArrayReference, y::ArrayReferenceMeta) = x == y.ref
40-
Base.:(==)(x::ArrayReferenceMeta, y::ArrayReference) = x.ref == y
41-
Base.:(==)(x::ArrayReference, y) = false
42-
Base.:(==)(x::ArrayReferenceMeta, y) = false
38+
# Errors preferable than silently working?
39+
# Base.:(==)(x::ArrayReference, y::ArrayReferenceMeta) = x == y.ref
40+
# Base.:(==)(x::ArrayReferenceMeta, y::ArrayReference) = x.ref == y
41+
# Base.:(==)(x::ArrayReference, y) = false
42+
# Base.:(==)(x::ArrayReferenceMeta, y) = false
4343

4444
@enum OperationType begin
4545
constant

test/printmethods.jl

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,20 @@
1010
@test occursin("Operation[", s)
1111
@test occursin("s = 0", s)
1212
@test occursin("s = LoopVectorization.vfmadd", s)
13+
14+
AmulBq = :(for m 1:M, n 1:N
15+
C[m,n] = zero(eltype(B))
16+
for k 1:K
17+
C[m,n] += A[m,k] * B[k,n]
18+
end
19+
end)
20+
lsAmulB = LoopVectorization.LoopSet(AmulBq);
21+
println(io, LoopVectorization.operations(lsAmulB))
22+
s = String(take!(io))
23+
@test occursin("Operation[", s)
24+
@test occursin("C[m, n] = ", s)
25+
@test occursin(" = A[m, k]", s)
26+
@test occursin(" = B[k, n]", s)
27+
@test occursin(" = LoopVectorization.vfmadd", s)
28+
@test occursin(" = LoopVectorization.reduce_to_add", s)
1329
end

0 commit comments

Comments
 (0)