Skip to content

Commit 1800d56

Browse files
committed
If no reduction index was found, don't try to insert
1 parent fe94ecf commit 1800d56

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

src/add_compute.jl

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -348,8 +348,10 @@ function add_reduction!(ls::LoopSet, var::Symbol, reduceddeps, deps, vparents, r
348348
# parent = getop(ls, var, elementbytes)
349349
# if length(reduceddeps) == 0
350350
if all(!in(deps), reduceddeps)
351-
insert!(vparents, reduction_ind, parent)
352-
mergesetv!(deps, loopdependencies(parent))
351+
if reduction_ind != 0
352+
insert!(vparents, reduction_ind, parent)
353+
mergesetv!(deps, loopdependencies(parent))
354+
end
353355
op = Operation(length(operations(ls)), var, elementbytes, instr, compute, deps, reduceddeps, vparents)
354356
pushop!(ls, op, var)
355357
else

test/gemm.jl

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -572,7 +572,7 @@
572572
# C[m,n] = Cmn_hi
573573
# end
574574
# end
575-
function doublegemm!(du, u, mat)
575+
function AB_plus_BA!(du, u, mat)
576576
@assert size(u, 1) == size(u, 2) == size(mat, 1) == size(mat, 2)
577577
for i2 in 1:size(u, 2), i1 in 1:size(u, 1)
578578
for sum_idx in 1:size(u, 1)
@@ -582,7 +582,7 @@
582582
return nothing
583583
end
584584

585-
function doublegemmavx!(du, u, mat)
585+
function AB_plus_BA_avx!(du, u, mat)
586586
@assert size(u, 1) == size(u, 2) == size(mat, 1) == size(mat, 2)
587587
@avx for i2 in 1:size(u, 2), i1 in 1:size(u, 1)
588588
for sum_idx in 1:size(u, 1)
@@ -671,8 +671,8 @@
671671
for M 48:54
672672
C0 = zeros(TC, M, M); C1 = zeros(TC, M, M);
673673
A = rand(R, M, M); B = rand(R, M, M);
674-
doublegemm!(C0, A, B)
675-
doublegemmavx!(C1, A, B)
674+
AB_plus_BA!(C0, A, B)
675+
AB_plus_BA_avx!(C1, A, B)
676676
@test C0 C1
677677
end
678678
# let T = Int32

0 commit comments

Comments
 (0)