Fix 106 by assigning consistent names to keep arrays identifiable.

Author: chriselrod

Project.toml

@@ -1,7 +1,7 @@
 name = "LoopVectorization"
 uuid = "bdcacae8-1622-11e9-2a5c-532679323890"
 authors = ["Chris Elrod <[email protected]>"]
-version = "0.7.7"
+version = "0.7.8"
 
 [deps]
 DocStringExtensions = "ffbed154-4ef7-542d-bbb7-c09d3a79fcae"

src/memory_ops_common.jl

@@ -1,9 +1,11 @@
+dottosym(x) = x
+dottosym(x::Expr) = Symbol(dottosym(x.args[1]), "###extractarray###", x.args[2].value)
 function extract_array_symbol_from_ref!(ls::LoopSet, ex::Expr, offset1::Int)::Symbol
     ar = ex.args[1 + offset1]
     if isa(ar, Symbol)
         return ar
     elseif isa(ar, Expr) && ar.head === :(.)
-        s = gensym(:extractedarray)
+        s = dottosym(ar)
         pushprepreamble!(ls, Expr(:(=), s, ar))
         return s
     else

test/miscellaneous.jl

@@ -622,14 +622,19 @@ using Test
         c_re
     end
 
-    function MatCalcWtD(m)
+
+    function MatCalcWtDW!(m)
         l, n = size(m.Wt)
-        @avx for j in 1:n
-            for i in 1:l
-                m.WtD[i, j] = m.Wt[i, j] * m.d[j]
-           end
-       end
+        fill!(m.Wt_D_W, 0)
+        @avx for k in 1: n
+            for j in 1:l
+                for i in 1:l
+                    m.Wt_D_W[i, j] += m.Wt[i, k] * m.Wt[j, k] * m.d[k]
+                end
+            end
+        end
     end
+
 
     for T ∈ (Float32, Float64)
         @show T, @__LINE__
@@ -816,9 +821,15 @@ using Test
         multiple_unrolls_split_depchains_avx!(c_re_2, a_re, b_re, a_im, b_im) # [1 1; 1 1]
         @test c_re_1 ≈ c_re_2
 
-        mh = (WtD = rand(T, 15,23), Wt = rand(T, 15,23), d = rand(T, 23))
-        MatCalcWtD(mh)
-        @test mh.WtD ≈ mh.Wt .* mh.d'
+        mh = (
+            Wt_D_W = Matrix{T}(undef, 181, 181),
+            Wt = rand(T, 181, 191),
+            d = rand(T, 191)
+        )
+        Wt_D_W = similar(mh.Wt_D_W)
+
+        MatCalcWtDW!(mh)
+        @test mh.Wt_D_W ≈ mh.Wt * Diagonal(mh.d) * mh.Wt'
 
 
     end