Make broadcasting define unknown functions as broadcasted.f, and change lowering to always reference the module.

Author: chriselrod

src/broadcast.jl

@@ -169,9 +169,9 @@ function add_broadcast!(
     elementbytes::Int
 ) where {N,S<:Base.Broadcast.AbstractArrayStyle{N},F,A}
     instr = get(FUNCTIONSYMBOLS, F) do
-        f = gensym(:func)
-        pushpreamble!(ls, Expr(:(=), f, Expr(:(.), bcname, QuoteNode(:f))))
-        Instruction(Symbol(""), f)
+        # f = gensym(:func)
+        # pushpreamble!(ls, Expr(:(=), f, Expr(:(.), bcname, QuoteNode(:f))))
+        Instruction(bcname, :f)
     end
     args = A.parameters
     Nargs = length(args)

src/costs.jl

@@ -14,11 +14,12 @@ end
 Instruction(instr::Symbol) = Instruction(:LoopVectorization, instr)
 Base.convert(::Type{Instruction}, instr::Symbol) = Instruction(instr)
 # lower(instr::Instruction) = Expr(:(.), instr.mod, QuoteNode(instr.instr))
+Base.convert(::Type{Expr}, instr::Instruction) = Expr(:(.), instr.mod, QuoteNode(instr.instr))
 function Base.Expr(instr::Instruction, args...)
     if instr.mod === :LoopVectorization
         Expr(:call, lv(instr.instr), args...)::Expr
     else
-        Expr(:call, instr.instr, args...)::Expr
+        Expr(:call, convert(Expr, instr), args...)::Expr
     end
 end
 Base.hash(instr::Instruction, h::UInt64) = hash(instr.instr, hash(instr.mod, h))
@@ -128,6 +129,8 @@ const COST = Dict{Instruction,InstructionCost}(
     Instruction(:(<)) => InstructionCost(1, 0.5),
     Instruction(:(>=)) => InstructionCost(1, 0.5),
     Instruction(:(<=)) => InstructionCost(1, 0.5),
+    Instruction(:(≥)) => InstructionCost(1, 0.5),
+    Instruction(:(≤)) => InstructionCost(1, 0.5),
     Instruction(:>>) => InstructionCost(1, 0.5),
     Instruction(:>>>) => InstructionCost(1, 0.5),
     Instruction(:<<) => InstructionCost(1, 0.5),

src/determinestrategy.jl

@@ -14,7 +14,8 @@ function cost(op::Operation, unrolled::Symbol, Wshift::Int, size_T::Int = op.ele
     isconstant(op) && return 0.0, 0, 1
     # Wshift == dependson(op, unrolled) ? Wshift : 0
     # c = first(cost(instruction(op), Wshift, size_T))::Int
-    instr = instruction(op)
+    instr = Instruction(:LoopVectorization, instruction(op).instr)
+    # instr = instruction(op)
     if length(parents(op)) == 1
         if instr == Instruction(:-) || instr === Instruction(:vsub) || instr == Instruction(:+) || instr == Instruction(:vadd)
             return 0.0, 0, 1