Skip to content

Commit 673b7e3

Browse files
committed
add parenthesis, remove some shows
1 parent d222607 commit 673b7e3

File tree

2 files changed

+1
-9
lines changed

2 files changed

+1
-9
lines changed

src/codegen/lower_load.jl

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ function prefetchisagoodidea(ls::LoopSet, op::Operation, td::UnrollArgs)
66
isvectorized(op) || return 0
77
((u₁ > 1) & (u₂max > 1)) || return 0
88
u₂loopsym === Symbol("##undefined##") && return 0
9-
# @show cache_lnsze(ls) reg_size(ls) pointer_from_objref(ls.register_size)
109
dontskip = (cache_lnsze(ls) ÷ reg_size(ls)) - 1
1110
# u₂loopsym is vectorized
1211
# u₁vectorized = vectorized === u₁loopsym
@@ -209,7 +208,6 @@ function lower_load_for_optranslation!(
209208
step₂ = gethint(step(u₂loop))
210209
# abs of steps are equal
211210
equal_steps = (step₁ == step₂) (posindicator 0x03)
212-
# @show step₁, step₂, posindicator, equal_steps
213211
_td = UnrollArgs(u₁loop, u₂loop, vloop, u₁, u₂max, Core.ifelse(equal_steps, 0, u₂max - 1))
214212
gespinds = mem_offset(op, _td, inds_by_ptroff, false, ls)
215213
ptr = vptr(op)
@@ -230,7 +228,6 @@ function lower_load_for_optranslation!(
230228
indices = copy(getindices(ref))
231229
# old_translation_index = indices[translationind]
232230
# indices[translationind] = u₁loop.itersymbol
233-
# @show indices, translationind, vloop
234231
# getindicesonly returns a view of `getindices`
235232
dummyref = ArrayReference(ref.array, indices, zero(getoffsets(ref)), getstrides(ref))
236233
# loopedindex[translationind] = true
@@ -249,10 +246,8 @@ function lower_load_for_optranslation!(
249246
end
250247
end
251248
end
252-
# @show indices
253249
_td = UnrollArgs(u₁loop, u₂loop, vloop, total_unroll, u₂max, -1)
254250
op.ref = dummymref
255-
# @show isu₁unrolled(op), isu₂unrolled(op)
256251
_lower_load!(q, ls, op, _td, mask)
257252
# set old values
258253
op.ref = mref
@@ -329,7 +324,6 @@ function _lower_load!(
329324
omop = offsetloadcollection(ls)
330325
@unpack opids, opidcollectionmap, batchedcollections, batchedcollectionmap = omop
331326
batchid, opind = batchedcollectionmap[identifier(op)]
332-
@show batchid, opind
333327
for (bid, oid) batchedcollectionmap # this relies on `for op ∈ ops` in codegen/operation_evaluation_order.jl
334328
if bid == batchid
335329
if oid == opind
@@ -362,7 +356,6 @@ function rejectcurly(ls::LoopSet, op::Operation, u₁loopsym::Symbol, vloopsym::
362356
li = op.ref.loopedindex
363357
AV = AU = false
364358
for (n,ind) enumerate(indices)
365-
# @show AU, op, n, ind, vloopsym, u₁loopsym
366359
if li[n]
367360
if ind === vloopsym
368361
AV && return true
@@ -374,7 +367,6 @@ function rejectcurly(ls::LoopSet, op::Operation, u₁loopsym::Symbol, vloopsym::
374367
end
375368
else
376369
opp = findop(parents(op), ind)
377-
# @show opp
378370
if isvectorized(opp)
379371
AV && return true
380372
AV = true

src/codegen/lower_memory_common.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -387,7 +387,7 @@ function add_memory_mask!(memopexpr::Expr, op::Operation, td::UnrollArgs, mask::
387387
# broadcast both, so can do so implicitly
388388
# this is true whether or not `condbroadcast`
389389
if !mask || (!isvectorized(op))
390-
if u₁ᵢ == 0 | (u == 1)
390+
if (u₁ᵢ == 0) | (u == 1)
391391
push!(memopexpr.args, condvar)
392392
else
393393
push!(memopexpr.args, :($getfield($getfield($condvar, 1), $(u₁ᵢ), false)))

0 commit comments

Comments
 (0)