Stores need to push stored op to front of parent list in case of offset; fixes #50.

Author: chriselrod

src/add_stores.jl

@@ -21,7 +21,7 @@ function add_copystore!(
     ls::LoopSet, parent::Operation, mpref::ArrayReferenceMetaPosition, elementbytes::Int
 )
     op = add_compute!(ls, gensym(), :identity, [parent], elementbytes)
-    pushfirst!(mpref.parents, parent)
+    # pushfirst!(mpref.parents, parent)
     add_store!(ls, name(op), mpref, elementbytes, op)
 end
 
@@ -49,7 +49,8 @@ function add_store!(
     else
         add_pvar = true
     end
-    pushparent!(parents, ldref, reduceddeps, parent)
+    pushfirst!(parents, parent)
+    update_deps!(ldref, reduceddeps, parent)
     op = Operation( id, name(mpref), elementbytes, :setindex!, memstore, mpref )#loopdependencies, reduceddeps, parents, mpref.mref )
     add_store!(ls, op, add_pvar)
 end

src/graphs.jl

@@ -467,7 +467,7 @@ function add_operation!(
         RHS_ref = array_reference_meta!(ls, array, rawindices, elementbytes)
         op = add_load!(ls, gensym(LHS_sym), RHS_ref, elementbytes)
         iop = add_compute!(ls, LHS_sym, :identity, [op], elementbytes)
-        pushfirst!(LHS_ref.parents, iop)
+        # pushfirst!(LHS_ref.parents, iop)
     elseif RHS.head === :call
         f = first(RHS.args)
         if f === :getindex

test/runtests.jl

@@ -230,6 +230,21 @@ end
                 b[i] = exp(a[i])
             end
         end
+        function offset_exp!(A, B)
+            @avx for i=1:size(A,1), j=1:size(B,2)
+	        A[i,j] = exp(B[i,j])
+            end
+        end
+        function offset_expavx!(A, B)
+            @avx for i=1:size(A,1), j=1:size(B,2)
+	        A[i,j] = exp(B[i,j])
+            end
+        end
+        function offset_exp_avx!(A, B)
+            @_avx for i=1:size(A,1), j=1:size(B,2)
+	        A[i,j] = exp(B[i,j])
+            end
+        end
 
         vexpsq = :(for i ∈ eachindex(a)
                    s += exp(a[i])
@@ -251,6 +266,19 @@ end
             end
             s
         end
+
+
+
+
+
+
+
+
+
+
+
+
+
         function myvexp_avx(a)
             s = zero(eltype(a))
             @_avx for i ∈ eachindex(a)
@@ -402,6 +430,16 @@ end
             @test r1 ≈ r2
             fill!(r2, NaN); calc_sins_avx!(r2)
             @test r1 ≈ r2
+
+            N,M = 47,53
+            B = reshape(cumsum(ones(T, 3N)),N,:)
+            A1 = zeros(T, N, M)
+            A2 = zeros(T, N, M)
+            offset_exp!(A1, B)
+            offset_expavx!(A2, B)
+            @test A1 ≈ A2
+            fill!(A2, 0); offset_exp_avx!(A2, B)
+            @test A1 ≈ A2
         end
     end