print file number check_args warning is coming from, fixes #333

Author: chriselrod

Project.toml

@@ -1,7 +1,7 @@
 name = "LoopVectorization"
 uuid = "bdcacae8-1622-11e9-2a5c-532679323890"
 authors = ["Chris Elrod <[email protected]>"]
-version = "0.12.67"
+version = "0.12.68"
 
 [deps]
 ArrayInterface = "4fba245c-0d91-5ea0-9b3e-6abc04ee57a9"

src/condense_loopset.jl

@@ -818,7 +818,8 @@ function setup_call(
   call = check_empty ? check_if_empty(ls, call) : call
   argfailure = make_crashy(make_fast(q))
   if warncheckarg ≠ 0
-    warning = :(@warn "`LoopVectorization.check_args` on your inputs failed; running fallback `@inbounds @fastmath` loop instead.\nUse `warn_check_args=false`, e.g. `@turbo warn_check_args=false ...`, to disable this warning.")
+    warnstring = "$(first(lnns)):\n`LoopVectorization.check_args` on your inputs failed; running fallback `@inbounds @fastmath` loop instead.\nUse `warn_check_args=false`, e.g. `@turbo warn_check_args=false ...`, to disable this warning."
+    warning = :(@warn $warnstring)
     warncheckarg > 0 && push!(warning.args, :(maxlog=$warncheckarg))
     argfailure = Expr(:block,  warning, argfailure)
   end

src/reconstruct_loopset.jl

@@ -713,7 +713,7 @@ Execute an `@turbo` block. The block's code is represented via the arguments:
 @generated function _turbo_!(
     ::Val{var"#UNROLL#"}, ::Val{var"#OPS#"}, ::Val{var"#ARF#"}, ::Val{var"#AM#"}, ::Val{var"#LPSYM#"}, ::Val{Tuple{var"#LB#",var"#V#"}}, var"#flattened#var#arguments#"::Vararg{Any,var"#num#vargs#"}
 ) where {var"#UNROLL#", var"#OPS#", var"#ARF#", var"#AM#", var"#LPSYM#", var"#LB#", var"#V#", var"#num#vargs#"}
-  1 + 1 # Irrelevant line you can comment out/in to force recompilation...
+  # 1 + 1 # Irrelevant line you can comment out/in to force recompilation...
   ls = _turbo_loopset(var"#OPS#", var"#ARF#", var"#AM#", var"#LPSYM#", var"#LB#".parameters, var"#V#".parameters, var"#UNROLL#")
   pushfirst!(ls.preamble.args, :(var"#lv#tuple#args#" = reassemble_tuple(Tuple{var"#LB#",var"#V#"}, var"#flattened#var#arguments#")))
   # return @show avx_body(ls, var"#UNROLL#")

test/fallback.jl

@@ -1,46 +1,49 @@
 
 @testset "Fall back behavior" begin
 
-    @show Float64, @__LINE__
-    function msd(x)
-        s = zero(eltype(x))
-        for i in eachindex(x)
-            s += x[i] * x[i]
-        end
-        s
+  @show Float64, @__LINE__
+  function msd(x)
+    s = zero(eltype(x))
+    for i in eachindex(x)
+      s += x[i] * x[i]
     end
-    function msdavx(x)
-        s = zero(eltype(x))
-        @turbo warn_check_args=true for i in eachindex(x)
-            s = muladd(x[i], x[i], s) # Avoids fastmath in fallback loop.
-        end
-        s
+    s
+  end
+  function msdavx(x)
+    s = zero(eltype(x))
+    @turbo warn_check_args=true for i in eachindex(x)
+      s = muladd(x[i], x[i], s) # Avoids fastmath in fallback loop.
     end
+    s
+  end
 
-    x = fill(8.0, 128);
-    x[1] = 1e9
-
-    @test @inferred LoopVectorization.check_args(x)
-    @test @inferred LoopVectorization.check_args(x, x)
-    @test @inferred LoopVectorization.check_args(x, x, x)
-    @test @inferred !LoopVectorization.check_args(view(x, [1,3,4,18]))
-    @test @inferred !LoopVectorization.check_args(FallbackArrayWrapper(x))
-    @test @inferred !LoopVectorization.check_args(FallbackArrayWrapper(x), x, x)
-    @test @inferred !LoopVectorization.check_args(x, FallbackArrayWrapper(x))
-    @test @inferred !LoopVectorization.check_args(x, FallbackArrayWrapper(x), x)
-    @test @inferred !LoopVectorization.check_args(x, x, FallbackArrayWrapper(x))
-    @test @inferred !LoopVectorization.check_args(x, x, FallbackArrayWrapper(x), FallbackArrayWrapper(x))
-    @test @inferred !LoopVectorization.check_args(['a'])
-    @test @inferred !LoopVectorization.check_args(Diagonal(x))
-
-    @test_nowarn msdavx(x)
-    @test_logs (:warn,"`LoopVectorization.check_args` on your inputs failed; running fallback `@inbounds @fastmath` loop instead.\nUse `warn_check_args=false`, e.g. `@turbo warn_check_args=false ...`, to disable this warning.") msdavx(FallbackArrayWrapper(x))
-    @test msdavx(FallbackArrayWrapper(x)) == 1e18
-    @test msd(x) == msdavx(FallbackArrayWrapper(x))
-    @test msdavx(x) != msdavx(FallbackArrayWrapper(x))
-
-    x = rand(1000); # should be long enough to make zero differences incredibly unlikely
-    @test exp.(x) != (@turbo exp.(x))
-    @test exp.(x) == (@turbo exp.(FallbackArrayWrapper(x)))
+  x = fill(8.0, 128);
+  x[1] = 1e9
+
+  @test @inferred LoopVectorization.check_args(x)
+  @test @inferred LoopVectorization.check_args(x, x)
+  @test @inferred LoopVectorization.check_args(x, x, x)
+  @test @inferred !LoopVectorization.check_args(view(x, [1,3,4,18]))
+  @test @inferred !LoopVectorization.check_args(FallbackArrayWrapper(x))
+  @test @inferred !LoopVectorization.check_args(FallbackArrayWrapper(x), x, x)
+  @test @inferred !LoopVectorization.check_args(x, FallbackArrayWrapper(x))
+  @test @inferred !LoopVectorization.check_args(x, FallbackArrayWrapper(x), x)
+  @test @inferred !LoopVectorization.check_args(x, x, FallbackArrayWrapper(x))
+  @test @inferred !LoopVectorization.check_args(x, x, FallbackArrayWrapper(x), FallbackArrayWrapper(x))
+  @test @inferred !LoopVectorization.check_args(['a'])
+  @test @inferred !LoopVectorization.check_args(Diagonal(x))
+
+  @test_nowarn msdavx(x)
+  lnn = LineNumberNode(14, joinpath(pkgdir(LoopVectorization),"test","fallback.jl"))
+  warnstring = "$(lnn):\n`LoopVectorization.check_args` on your inputs failed; running fallback `@inbounds @fastmath` loop instead.\nUse `warn_check_args=false`, e.g. `@turbo warn_check_args=false ...`, to disable this warning."
+
+  @test_logs (:warn,warnstring) msdavx(FallbackArrayWrapper(x))
+  @test msdavx(FallbackArrayWrapper(x)) == 1e18
+  @test msd(x) == msdavx(FallbackArrayWrapper(x))
+  @test msdavx(x) != msdavx(FallbackArrayWrapper(x))
+
+  x = rand(1000); # should be long enough to make zero differences incredibly unlikely
+  @test exp.(x) != (@turbo exp.(x))
+  @test exp.(x) == (@turbo exp.(FallbackArrayWrapper(x)))
 end