Benchmark fixes.

Author: chriselrod

benchmark/benchmarkflops.jl

@@ -407,11 +407,11 @@ function benchmark_random_access(sizes)
     br = BenchmarkResult(tests, sizes)
     for (i,s) ∈ enumerate(sizes)
         A, C = totwotuple(s)
-        P = rand(A, C);
+        P = rand(A, C) .+= 0.5;
         basis = rand(1:C, A, C);
-        coefs = randn(C)
+        coefs = randn(C);
         n_gflop = 1e-9*(A*C + C)
-        p = randomaccess(P, basis, coefs)
+        p = randomaccess(P, basis, coefs);
         br[1,i] = n_gflop / @belapsed  randomaccess($P, $basis, $coefs)
         br[2,i] = n_gflop / @belapsed crandomaccess($P, $basis, $coefs)
         @assert p ≈ crandomaccess(P, basis, coefs) "Clang wrong?"

benchmark/driver.jl

@@ -47,7 +47,7 @@ AtmulB_bench = fetch(AtmulB_future)
 AmulBt_bench = fetch(AmulBt_future)
 Atmulvb_bench = fetch(Atmulvb_future)
 
-v = 2
+v = 3
 const PICTURES = "/home/chriselrod/Pictures"
 save(joinpath(PICTURES, "bench_gemm_v$v.png"), plot(gemm_bench));
 save(joinpath(PICTURES, "bench_AtmulB_v$v.png"), plot(AtmulB_bench));
@@ -60,7 +60,7 @@ save(joinpath(PICTURES, "bench_exp_v$v.png"), plot(exp_bench));
 save(joinpath(PICTURES, "bench_aplusBc_v$v.png"), plot(aplusBc_bench));
 save(joinpath(PICTURES, "bench_AplusAt_v$v.png"), plot(AplusAt_bench));
 save(joinpath(PICTURES, "bench_random_access_v$v.png"), plot(randomaccess_bench));
-save(joinpath(PICTURES, "bench_AmulBt_v$b.png"), plot(AmulBt_bench));
+save(joinpath(PICTURES, "bench_AmulBt_v$v.png"), plot(AmulBt_bench));
 save(joinpath(PICTURES, "bench_Atmulvb_v$v.png"), plot(Atmulvb_bench));
 
 plot(gemm_bench)

benchmark/loadsharedlibs.jl

@@ -306,7 +306,7 @@ for (prefix,Cshared,Fshared) ∈ ((Symbol(""),LIBCTEST,LIBFTEST), (:i,LIBICTEST,
         A, C = size(P)
         p = Ref{Float64}()
         ccall(
-            (:randomaccess, $Cshared), Cvoid,
+            (:randomaccess, $Fshared), Cvoid,
             (Ref{Float64}, Ptr{Float64}, Ptr{Clong}, Ptr{Float64}, Ref{Clong}, Ref{Clong}),
             p, P, basis, coefs, Ref(A), Ref(C)
         )

benchmark/looptests.f90

@@ -292,9 +292,8 @@ subroutine AplusAtbuiltin(B, A, N) BIND(C, name="AplusAtbuiltin")
       B = A + transpose(A)
     end subroutine AplusAtbuiltin
     subroutine randomaccess(pp, P, basis, coefs, A, C) BIND(C, name="randomaccess")
-      integer(C_long), intent(in) :: A, C
+      integer(C_long), intent(in) :: A, C, basis(A,C)
       real(C_double), intent(in) :: P(A,C), coefs(C)
-      integer(C_long), intent(in) :: basis(A,C)
       real(C_double), intent(out) :: pp
       real(C_double) :: pc
       integer(C_long) :: aa, cc

benchmark/looptests.jl

@@ -20,8 +20,9 @@ end
         C[m,n] = Cₘₙ
     end
 end
-@inline function jgemm!(C, A, B::Adjoint)
+@inline function jgemm!(C, A, Bᵀ::Adjoint)
     C .= 0
+    B = parent(B)
     M, N = size(C); K = size(B,1)
     @inbounds for k ∈ 1:K, n ∈ 1:N
         @simd ivdep for m ∈ 1:M

benchmark/plotbenchmarks.jl

@@ -29,8 +29,8 @@ function plot(br::BenchmarkResult)
         x = :Size,
         y = :GFLOPS,
         color = :Method,
-        width = 549,
-        height = 372
+        width = 720,
+        height = 480
     )
 end