Define vmaterialize!(dest, ::Product).

Author: chriselrod

src/broadcast.jl

@@ -247,7 +247,7 @@ end
 # function vmaterialize!(
 @generated function vmaterialize!(
     dest::StridedArray{T,N}, bc::BC, ::Val{Mod}
-) where {T <: NativeTypes, N, BC <: Broadcasted, Mod}
+) where {T <: NativeTypes, N, BC <: Union{Broadcasted,Product}, Mod}
     # we have an N dimensional loop.
     # need to construct the LoopSet
     # @show typeof(dest)
@@ -277,7 +277,7 @@ end
 end
 @generated function vmaterialize!(
     dest′::Union{Adjoint{T,A},Transpose{T,A}}, bc::BC, ::Val{Mod}
-) where {T <: NativeTypes, N, A <: StridedArray{T,N}, BC <: Broadcasted, Mod}
+) where {T <: NativeTypes, N, A <: StridedArray{T,N}, BC <: Union{Broadcasted,Product}, Mod}
     # we have an N dimensional loop.
     # need to construct the LoopSet
     loopsyms = [gensym(:n) for n ∈ 1:N]

test/broadcast.jl

@@ -78,18 +78,19 @@
         A = rand(R,M,K); B = rand(R,K,N); C = rand(R,M,N);
         At = copy(A');
         D1 = C .+ A * B;
-        D2 = @avx C .+ A *ˡ B;
+        D2 = @avx C .+ A .*ˡ B;
         @test D1 ≈ D2
-        fill!(D2, -999999); D2 = @avx C .+ At' *ˡ B;
+        fill!(D2, -999999); D2 = @avx C .+ At' .*ˡ B;
         @test D1 ≈ D2
+        fill!(D2, -999999); @test A * B ≈ (@. D2 = A *ˡ B)
         D1 .= view(C, 1, :)' .+ A * B;
         fill!(D2, -999999);
-        @avx D2 .= view(C, 1, :)' .+ A *ˡ B;
+        @avx D2 .= view(C, 1, :)' .+ A .*ˡ B;
         @test D1 ≈ D2
         C3d = rand(R,3,M,N);
         D1 .= view(C3d, 1, :, :) .+ A * B;
         fill!(D2, -999999);
-        @avx D2 .= view(C3d, 1, :, :) .+ A *ˡ B;
+        @avx D2 .= view(C3d, 1, :, :) .+ A .*ˡ B;
         @test D1 ≈ D2
 
         D1 .= 9999;