Make @avxt on broadcast not error, support element types of pointers not defined in LV module

Author: chriselrod

Project.toml

@@ -1,7 +1,7 @@
 name = "LoopVectorization"
 uuid = "bdcacae8-1622-11e9-2a5c-532679323890"
 authors = ["Chris Elrod <[email protected]>"]
-version = "0.12.3"
+version = "0.12.4"
 
 [deps]
 ArrayInterface = "4fba245c-0d91-5ea0-9b3e-6abc04ee57a9"

src/condense_loopset.jl

@@ -303,7 +303,7 @@ end
     ::StaticInt{RS}, ::StaticInt{AR}, ::StaticInt{NT},
     ::StaticInt{CLS}, ::StaticInt{L1}, ::StaticInt{L2}, ::StaticInt{L3}
 ) where {inline,u₁,u₂,thread,W,RS,AR,CLS,L1,L2,L3,NT}
-    nt = min(thread, NT % UInt)
+    nt = min(thread % UInt, NT % UInt)
     t = Expr(:tuple, inline, u₁, u₂, W, RS, AR, CLS, L1,L2,L3, nt)
     Expr(:call, Expr(:curly, :Val, t))
 end

src/reconstruct_loopset.jl

@@ -171,16 +171,6 @@ function rank_to_sortperm(R::NTuple{N,Int}) where {N}
     end
     sp
 end
-# sptrs::Expr, ls::LoopSet, ar::ArrayReferenceMeta, @nospecialize(_::Type{Core.LLVMPtr{T,0}}),
-function add_mref!(
-    sptrs::Expr, ls::LoopSet, ar::ArrayReferenceMeta, @nospecialize(_::Type{Ptr{T}}),
-    C::Int, B::Int, sp::NTuple{N,Int}, name::Symbol
-) where {T,N}
-    Tsym::Symbol = get(VectorizationBase.JULIA_TYPES, T) do
-        Symbol(T)
-    end
-    add_mref_ptr!(sptrs, ls, ar, Tsym, C, B, sp, name)
-end
 function loop_indexes_bit!(ls::LoopSet, ar::ArrayReferenceMeta)
     li = ar.loopedindex;
     ind = first(getindices(ar))
@@ -189,17 +179,17 @@ function loop_indexes_bit!(ls::LoopSet, ar::ArrayReferenceMeta)
     ls.loopindexesbit[getloopid(ls,ind)] = true
     nothing
 end
-function add_mref_ptr!(
-    sptrs::Expr, ls::LoopSet, ar::ArrayReferenceMeta, Tsym::Symbol,
+function add_mref!(
+    sptrs::Expr, ls::LoopSet, ar::ArrayReferenceMeta, @nospecialize(_::Type{Ptr{T}}),
     C::Int, B::Int, sp::NTuple{N,Int}, name::Symbol
-) where {N}
+) where {T,N}
     @assert B ≤ 0 "Batched arrays not supported yet."
     # maybe no change needed? -- optimize common case
     column_major = ntuple(identity, N)
     li = ar.loopedindex;
     if sp === column_major || isone(length(li))
         # don't set `bit` to true if our vector width is ≥ 8
-        ((Tsym === :Bit) && (ls.vector_width[] < 8)) && loop_indexes_bit!(ls, ar)
+        ((T === VectorizationBase.Bit) && (ls.vector_width[] < 8)) && loop_indexes_bit!(ls, ar)
         return extract_gsp!(sptrs, name)
     end
     permute_mref!(ar, C, sp)
@@ -216,8 +206,8 @@ function add_mref_ptr!(
         push!(strd_tup.args, Expr(:call, gf, strides, p, false))
         push!(offsets_tup.args, Expr(:call, gf, offsets, p, false))
     end
-    #TODO: fix for `Tsym === Bit`.
-    sptype = Expr(:curly, lv(:StridedPointer), Tsym, N, (C == -1 ? -1 : 1), B, column_major)
+    #TODO: fix for `T === Bit`.
+    sptype = Expr(:curly, lv(:StridedPointer), T, N, (C == -1 ? -1 : 1), B, column_major)
     sptr = Expr(:call, sptype, Expr(:call, :pointer, tmpsp), strd_tup, offsets_tup)
     pushpreamble!(ls, Expr(:(=), name, sptr))
     nothing