Skip to content

Commit f4a4aad

Browse files
committed
LineNumberNode's file arg should be a Symbol.
1 parent fd93ff6 commit f4a4aad

File tree

5 files changed

+15
-15
lines changed

5 files changed

+15
-15
lines changed

src/broadcast.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ function add_broadcast!(
5252
mB = gensym(:Bₖₙ)
5353
pushpreamble!(ls, Expr(:(=), mA, Expr(:(.), bcname, QuoteNode(:a))))
5454
pushpreamble!(ls, Expr(:(=), mB, Expr(:(.), bcname, QuoteNode(:b))))
55-
pushpreamble!(ls, Expr(:(=), K, Expr(:macrocall, Symbol("@inbounds"), LineNumberNode(@__LINE__,@__FILE__), Expr(:ref, Expr(:call, :size, mB), 1))))
55+
pushpreamble!(ls, Expr(:(=), K, Expr(:macrocall, Symbol("@inbounds"), LineNumberNode(@__LINE__,Symbol(@__FILE__)), Expr(:ref, Expr(:call, :size, mB), 1))))
5656
k = gensym(:k)
5757
add_loop!(ls, Loop(k, 0, K), k)
5858
m = loopsyms[1];
@@ -182,7 +182,7 @@ function add_broadcast!(
182182
# reduceddeps = Symbol[]
183183
for (i,arg) enumerate(args)
184184
argname = gensym(:arg)
185-
pushpreamble!(ls, Expr(:(=), argname, Expr(:macrocall, Symbol("@inbounds"), LineNumberNode(@__LINE__,@__FILE__), Expr(:ref, bcargs, i))))
185+
pushpreamble!(ls, Expr(:(=), argname, Expr(:macrocall, Symbol("@inbounds"), LineNumberNode(@__LINE__,Symbol(@__FILE__)), Expr(:ref, bcargs, i))))
186186
# dynamic dispatch
187187
parent = add_broadcast!(ls, gensym(:temp), argname, loopsyms, arg, elementbytes)::Operation
188188
push!(parents, parent)

src/condense_loopset.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ end
224224
push!(call.args, Expr(:ref, :vargs, n))
225225
end
226226
push!(q.args, call)
227-
Expr(:macrocall, Symbol("@inbounds"), LineNumberNode(@__LINE__, @__FILE__), q)
227+
Expr(:macrocall, Symbol("@inbounds"), LineNumberNode(@__LINE__, Symbol(@__FILE__)), q)
228228
end
229229

230230
# Try to condense in type stable manner

src/lowering.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ function reduce_expr!(q::Expr, ls::LoopSet, U::Int)
206206
end
207207
function gc_preserve(ls::LoopSet, q::Expr)
208208
length(ls.includedactualarrays) == 0 && return q
209-
gcp = Expr(:macrocall, Expr(:(.), :GC, QuoteNode(Symbol("@preserve"))), LineNumberNode(@__LINE__, @__FILE__))
209+
gcp = Expr(:macrocall, Expr(:(.), :GC, QuoteNode(Symbol("@preserve"))), LineNumberNode(@__LINE__, Symbol(@__FILE__)))
210210
for array ls.includedactualarrays
211211
push!(gcp.args, array)
212212
end

src/map.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ function vmap_quote(N, ::Type{T}) where {T}
1010
bodymask = Expr(:block, Expr(:(=), :__mask__, Expr(:call, :mask, val, Expr(:call, :&, :M, W-1))), Expr(:call, :vstore!, :vdest, fcallmask, :m, :__mask__))
1111
for n 1:N
1212
arg_n = Symbol(:varg_,n)
13-
push!(q.args, Expr(:(=), arg_n, Expr(:macrocall, Symbol("@inbounds"), LineNumberNode(@__LINE__,@__FILE__), Expr(:call, :vectorizable, Expr(:ref, :args, n)))))
13+
push!(q.args, Expr(:(=), arg_n, Expr(:macrocall, Symbol("@inbounds"), LineNumberNode(@__LINE__,Symbol(@__FILE__)), Expr(:call, :vectorizable, Expr(:ref, :args, n)))))
1414
push!(fcall.args, Expr(:call, :vload, val, arg_n, :m))
1515
push!(fcallmask.args, Expr(:call, :vload, val, arg_n, :m, :__mask__))
1616
end

src/reconstruct_loopset.jl

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
function Loop(ls::LoopSet, l::Int, ::Type{UnitRange{Int}})
22
start = gensym(:loopstart); stop = gensym(:loopstop)
3-
pushpreamble!(ls, Expr(:(=), start, Expr(:macrocall, Symbol("@inbounds"), LineNumberNode(@__LINE__, @__FILE__), Expr(:(.), Expr(:ref, :lb, l), QuoteNode(:start)))))
4-
pushpreamble!(ls, Expr(:(=), stop, Expr(:macrocall, Symbol("@inbounds"), LineNumberNode(@__LINE__, @__FILE__), Expr(:(.), Expr(:ref, :lb, l), QuoteNode(:stop)))))
3+
pushpreamble!(ls, Expr(:(=), start, Expr(:macrocall, Symbol("@inbounds"), LineNumberNode(@__LINE__, Symbol(@__FILE__)), Expr(:(.), Expr(:ref, :lb, l), QuoteNode(:start)))))
4+
pushpreamble!(ls, Expr(:(=), stop, Expr(:macrocall, Symbol("@inbounds"), LineNumberNode(@__LINE__, Symbol(@__FILE__)), Expr(:(.), Expr(:ref, :lb, l), QuoteNode(:stop)))))
55
Loop(gensym(:n), 0, 1024, start, stop, false, false)::Loop
66
end
77
function Loop(ls::LoopSet, l::Int, ::Type{StaticUpperUnitRange{U}}) where {U}
88
start = gensym(:loopstart)
9-
pushpreamble!(ls, Expr(:(=), start, Expr(:macrocall, Symbol("@inbounds"), LineNumberNode(@__LINE__, @__FILE__), Expr(:(.), Expr(:ref, :lb, l), QuoteNode(:L)))))
9+
pushpreamble!(ls, Expr(:(=), start, Expr(:macrocall, Symbol("@inbounds"), LineNumberNode(@__LINE__, Symbol(@__FILE__)), Expr(:(.), Expr(:ref, :lb, l), QuoteNode(:L)))))
1010
Loop(gensym(:n), U - 1024, U, start, Symbol(""), false, true)::Loop
1111
end
1212
function Loop(ls::LoopSet, l::Int, ::Type{StaticLowerUnitRange{L}}) where {L}
1313
stop = gensym(:loopstop)
14-
pushpreamble!(ls, Expr(:(=), stop, Expr(:macrocall, Symbol("@inbounds"), LineNumberNode(@__LINE__, @__FILE__), Expr(:(.), Expr(:ref, :lb, l), QuoteNode(:U)))))
14+
pushpreamble!(ls, Expr(:(=), stop, Expr(:macrocall, Symbol("@inbounds"), LineNumberNode(@__LINE__, Symbol(@__FILE__)), Expr(:(.), Expr(:ref, :lb, l), QuoteNode(:U)))))
1515
Loop(gensym(:n), L, L + 1024, Symbol(""), stop, true, false)::Loop
1616
end
1717
function Loop(ls, l, ::Type{StaticUnitRange{L,U}}) where {L,U}
@@ -55,7 +55,7 @@ function ArrayReferenceMeta(
5555
)
5656
end
5757

58-
extract_varg(i) = Expr(:macrocall, Symbol("@inbounds"), LineNumberNode(@__LINE__, @__FILE__), Expr(:ref, :vargs, i))
58+
extract_varg(i) = Expr(:macrocall, Symbol("@inbounds"), LineNumberNode(@__LINE__, Symbol(@__FILE__)), Expr(:ref, :vargs, i))
5959
pushvarg!(ls::LoopSet, ar::ArrayReferenceMeta, i) = pushpreamble!(ls, Expr(:(=), vptr(ar), extract_varg(i)))
6060
function pushvarg′!(ls::LoopSet, ar::ArrayReferenceMeta, i)
6161
reverse!(ar.loopedindex); reverse!(getindices(ar)) # reverse the listed indices here, and transpose it to make it column major
@@ -81,7 +81,7 @@ function add_mref!(ls::LoopSet, ar::ArrayReferenceMeta, i::Int, ::Type{SparseStr
8181
pushvarg!(ls, ar, i)
8282
pushfirst!(getindices(ar), Symbol("##DISCONTIGUOUSSUBARRAY##"))
8383
end
84-
function add_mref!(ls::LoopSet, ar::ArrayReferenceMeta, i::Int, ::Type{MappedStridedPointer{F,T,P}}) where {F,T,P}
84+
function add_mref!(ls::LoopSet, ar::ArrayReferenceMeta, i::Int, ::Type{VectorizationBase.MappedStridedPointer{F,T,P}}) where {F,T,P}
8585
add_mref!(ls, ar, i, P)
8686
end
8787
function add_mref!(ls::LoopSet, ar::ArrayReferenceMeta, i::Int, ::Type{LoopValue})
@@ -113,7 +113,7 @@ function process_metadata!(ls::LoopSet, AM, num_arrays::Int)::Vector{Symbol}
113113
sii = si::Int
114114
s = gensym(:symlicm)
115115
push!(ls.preamble_symsym, (si, s))
116-
pushpreamble!(ls, Expr(:(=), s, Expr(:macrocall, Symbol("@inbounds"), LineNumberNode(@__LINE__,@__FILE__), Expr(:ref, :vargs, num_arrays + i))))
116+
pushpreamble!(ls, Expr(:(=), s, Expr(:macrocall, Symbol("@inbounds"), LineNumberNode(@__LINE__,Symbol(@__FILE__)), Expr(:ref, :vargs, num_arrays + i))))
117117
end
118118
append!(ls.preamble_symint, AM[4].parameters)
119119
append!(ls.preamble_symfloat, AM[5].parameters)
@@ -165,7 +165,7 @@ function add_parents_to_ops!(ls::LoopSet, ops::Vector{OperationStruct}, constoff
165165
instr = instruction(op)
166166
if instr != LOOPCONSTANT && instr.mod !== :numericconstant
167167
constoffset += 1
168-
pushpreamble!(ls, Expr(:(=), instr.instr, Expr(:macrocall, Symbol("@inbounds"), LineNumberNode(@__LINE__, @__FILE__), Expr(:ref, :vargs, constoffset))))
168+
pushpreamble!(ls, Expr(:(=), instr.instr, Expr(:macrocall, Symbol("@inbounds"), LineNumberNode(@__LINE__, Symbol(@__FILE__)), Expr(:ref, :vargs, constoffset))))
169169
end
170170
end
171171
end
@@ -189,7 +189,7 @@ typeeltype(::Type{<:AbstractRange{T}}) where {T} = T
189189

190190
function add_array_symbols!(ls::LoopSet, arraysymbolinds::Vector{Symbol}, offset::Int)
191191
for (i,as) enumerate(arraysymbolinds)
192-
pushpreamble!(ls, Expr(:(=), as, Expr(:macrocall, Symbol("@inbounds"), LineNumberNode(@__LINE__, @__FILE__), Expr(:ref, :vargs, i + offset))))
192+
pushpreamble!(ls, Expr(:(=), as, Expr(:macrocall, Symbol("@inbounds"), LineNumberNode(@__LINE__, Symbol(@__FILE__)), Expr(:ref, :vargs, i + offset))))
193193
end
194194
end
195195
function extract_external_functions!(ls::LoopSet, offset::Int)
@@ -198,7 +198,7 @@ function extract_external_functions!(ls::LoopSet, offset::Int)
198198
instr = instruction(op)
199199
if instr.mod != :LoopVectorization
200200
offset += 1
201-
pushpreamble!(ls, Expr(:(=), instr.instr, Expr(:macrocall, Symbol("@inbounds"), LineNumberNode(@__LINE__, @__FILE__), Expr(:ref, :vargs, offset))))
201+
pushpreamble!(ls, Expr(:(=), instr.instr, Expr(:macrocall, Symbol("@inbounds"), LineNumberNode(@__LINE__, Symbol(@__FILE__)), Expr(:ref, :vargs, offset))))
202202
end
203203
end
204204
end

0 commit comments

Comments
 (0)