Some subsetview fixes, sin/cos_fast cost update

Author: chriselrod

Project.toml

@@ -1,7 +1,7 @@
 name = "LoopVectorization"
 uuid = "bdcacae8-1622-11e9-2a5c-532679323890"
 authors = ["Chris Elrod <[email protected]>"]
-version = "0.12.74"
+version = "0.12.75"
 
 [deps]
 ArrayInterface = "4fba245c-0d91-5ea0-9b3e-6abc04ee57a9"

src/modeling/costs.jl

@@ -228,19 +228,19 @@ const COST = Dict{Symbol,InstructionCost}(
     :(^) => InstructionCost(-3.0,200.0,400.0,26), # FIXME
     :pow_fast => InstructionCost(-3.0,200.0,400.0,26), # FIXME
     :sin => InstructionCost(-3,30.0,60.0,23),
-    :cos => InstructionCost(-3,27.0,60.0,26),
+    :cos => InstructionCost(-3,30.0,60.0,26),
     :sincos => InstructionCost(-3,37.0,85.0,26),
-    :sincos_fast => InstructionCost(-3,37.0,85.0,26),
+    :sincos_fast => InstructionCost(-3,30.0,60.0,26),
     :sinpi => InstructionCost(18,15.0,68.0,23),
     :cospi => InstructionCost(18,15.0,68.0,26),
     :sincospi => InstructionCost(25,37.0,70.0,26),
     :log_fast => InstructionCost(20,20.0,40.0,20),
     :exp_fast => InstructionCost(20,20.0,20.0,18),
-    :sin_fast => InstructionCost(18,15.0,68.0,23),
-    :cos_fast => InstructionCost(18,15.0,68.0,26),
-    :sinpi_fast => InstructionCost(18,15.0,68.0,23),
-    :cospi_fast => InstructionCost(18,15.0,68.0,26),
-    :sincospi_fast => InstructionCost(25,22.0,70.0,26),
+    :sin_fast => InstructionCost(18,25.0,50.0,23),
+    :cos_fast => InstructionCost(18,25.0,50.0,26),
+    :sinpi_fast => InstructionCost(18,25.0,50.0,23),
+    :cospi_fast => InstructionCost(18,25.0,50.0,26),
+    :sincospi_fast => InstructionCost(25,25.0,50.0,26),
     :tanh => InstructionCost(-3.0,80.0,160.0,26), # FIXME
     :tanh_fast => InstructionCost(-3.0,30.0,60.0,20), # FIXME
     :sigmoid_fast => InstructionCost(-3.0,16.0,66.0,15), # FIXME

src/vectorizationbase_compat/subsetview.jl

@@ -30,6 +30,11 @@ end
     stridedpointer($gptr, si, StaticInt{$B}())
   end
 end
+@inline _subsetview(ptr::AbstractStridedPointer, ::StaticInt{I}, J::Tuple{}) where {I} = ptr
+@inline _subsetview(ptr::AbstractStridedPointer, ::StaticInt{I}, J::Tuple{J1}) where {I,J1} = subsetview(ptr, StaticInt{I}(), first(J))
+@inline _subsetview(ptr::AbstractStridedPointer, ::StaticInt{I}, J::Tuple{J1,J2,Vararg}) where {I,J1,J2} = _subsetview(subsetview(ptr, StaticInt{I}(), first(J)), StaticInt{I}(), Base.tail(J))
+@inline subsetview(ptr::AbstractStridedPointer, ::StaticInt{I}, J::CartesianIndex) where {I} = _subsetview(ptr, StaticInt{I}(), Tuple(J))
+
 @inline _gesp(sp::VectorizationBase.FastRange, ::StaticInt{1}, i) = gesp(sp, (i,))
 @generated function _gesp(sp::AbstractStridedPointer{T,N}, ::StaticInt{I}, i::Integer) where {I,N,T}
   t = Expr(:tuple)