Threads fail silently on error

[efaulhaber]

MWE:

julia> x = zeros(Int, 5, 10)
5×10 Matrix{Int64}:
 0  0  0  0  0  0  0  0  0  0
 0  0  0  0  0  0  0  0  0  0
 0  0  0  0  0  0  0  0  0  0
 0  0  0  0  0  0  0  0  0  0
 0  0  0  0  0  0  0  0  0  0

julia> @batch for j in axes(x, 2)
           for i in 1:5
               if i > 3 && j in (2, 4, 9)
                   error("some error")
               end
               x[i, j] = 1
           end
       end

julia> x
5×10 Matrix{Int64}:
 1  1  1  1  1  1  1  1  1  1
 1  1  1  1  1  1  1  1  1  1
 1  1  1  1  1  1  1  1  1  1
 1  0  1  0  1  1  1  1  0  1
 1  0  1  0  1  1  1  1  0  1

I want to update the columns of x and run into an error. Instead of showing the error, the relevant threads just stop silently.
In an actual code, I might want to update some object, which failed for some reason. But Polyester.jl doesn't tell me it failed, so I might continue with this broken x, not realizing it is in an invalid (incompletely updated) state, causing unpredicted behavior down the road.

[chriselrod]

wait is defined here, returning true if there was an error, and false otherwise:
https://github.com/JuliaSIMD/ThreadingUtilities.jl/blob/284d17aab09a3919759045995955d4090d5e183d/src/threadtasks.jl#L70-L92

wait is called here without checking:

Polyester.jl/src/batch.jl

Line 257 in 515e2cf

ThreadingUtilities.wait(tid)

To actually print the task, you'd have to update the code in ThreadingUtilities.checktask.
checktask isn't inlined, so making it bigger by adding printing code shouldn't be a big deal.

[efaulhaber]

I gave it a shot in JuliaSIMD/ThreadingUtilities.jl#54 and #154.

[DanielDoehring]

Possibly related #128

[efaulhaber]

Closed by JuliaSIMD/ThreadingUtilities.jl#54 and #154.