Apply suggestions from code review

Co-authored-by: Tangi Migot <[email protected]>

Author: amontoison

docs/src/sparse.md

@@ -50,11 +50,7 @@ The `:direct` coloring mode is numerically more stable and may be preferable for
 
 ## Extracting sparsity patterns
 
-`ADNLPModels.jl` provides the function `get_sparsity_pattern` to retrieve the sparsity patterns of the Jacobian or Hessian from a model.
-
-```@docs
-get_sparsity_pattern
-```
+`ADNLPModels.jl` provides the function [`get_sparsity_pattern`](@ref) to retrieve the sparsity patterns of the Jacobian or Hessian from a model.
 
 ```@example ex3
 using SparseArrays, ADNLPModels, NLPModels
@@ -100,7 +96,7 @@ ncon = 5
 
 f(x) = sum((x[i] - i)^2 for i = 1:nvar) + x[nvar] * sum(x[j] for j = 1:nvar-1)
 
-H = SparseMatrixCSC{Bool,Int}(
+H = SparseMatrixCSC{Bool, Int}(
   [ 1  0  0  0  0  0  0  0  0  1 ;
     0  1  0  0  0  0  0  0  0  1 ;
     0  0  1  0  0  0  0  0  0  1 ;
@@ -122,7 +118,7 @@ function c!(cx, x)
   return cx
 end
 
-J = SparseMatrixCSC{Bool,Int}(
+J = SparseMatrixCSC{Bool, Int}(
   [ 1  1  0  0  0  0  0  0  0  0 ;
     1  1  1  0  0  0  0  0  0  0 ;
     0  1  1  1  0  0  0  0  0  0 ;
@@ -145,7 +141,6 @@ nlp = ADNLPModel!(f, x0, lvar, uvar, c!, lcon, ucon, jacobian_backend=J_backend,
 
 The section ["providing the sparsity pattern for sparse derivatives"](@ref sparsity-pattern) illustrates this feature with a more advanced application.
 
-
 ### Acknowledgements
 
 The package [`SparseConnectivityTracer.jl`](https://github.com/adrhill/SparseConnectivityTracer.jl) is used to compute the sparsity pattern of Jacobians and Hessians.

src/sparsity_pattern.jl

@@ -77,7 +77,10 @@ function get_sparsity_pattern(model::ADModel, derivate::Symbol)
   if (derivate != :jacobian) && (derivate != :hessian)
     if model isa AbstractADNLPModel
       error("The only supported sparse derivates for an AbstractADNLPModel are `:jacobian` and `:hessian`.")
-    elseif (derivate != :jacobian_residual) && (derivate != :hessian_resiual)
+    elseif  (model isa AbstractADNLSModel) && (derivate != :jacobian_residual) && (derivate != :hessian_resiual)
+    # ...
+    else
+    # ERROR
       error("The only supported sparse derivates for an AbstractADNLSModel are `:jacobian`, `:jacobian_residual`, `:hessian` and `:hessian_resiual`.")
     end
   end