try fix using pdata with shifts for least-squares (segfault locally)

Author: tmigot

src/main.jl

@@ -86,6 +86,21 @@ function preprocess(
     return PData
 end
 
+function preprocess(
+  stp::NLPStopping,
+  PData::PDataIterLS,
+  workspace::TRARCWorkspace{T,S,Hess},
+  ∇f,
+  norm_∇f,
+  α,
+) where {T,S,Hess<:HessGaussNewtonOp}
+  max_hprod = stp.meta.max_cntrs[:neval_jprod_residual]
+  Fx = workspace.Fx
+  Jx = jac_op_residual!(stp.pb, workspace.xt, workspace.Hstruct.Jv, workspace.Hstruct.Jtv)
+  PData = ARCTR.preprocess(PData, Jx, Fx, norm_∇f, neval_jprod_residual(stp.pb), max_hprod, α)
+  return PData
+end
+
 function compute_direction(
     stp::NLPStopping,
     PData::TPData,
@@ -143,8 +158,8 @@ function TRARC(
 ) where {Pb,M,SRC,MStp,LoS,S,T,Hess,ParamData}
     nlp = nlp_stop.pb
 
-    if ParamData == PDataNLSST
-        PData = PDataNLSST(S, T, nlp.meta.nvar, nlp.nls_meta.nequ; kwargs...)
+    if ParamData in (PDataNLSST, PDataLSKARC)
+        PData = ParamData(S, T, nlp.meta.nvar, nlp.nls_meta.nequ; kwargs...)
     else
         PData = ParamData(S, T, nlp.meta.nvar; kwargs...)
     end

src/utils/pdata_struct.jl

@@ -119,7 +119,7 @@ end
     PDataLSKARC(::Type{S}, ::Type{T}, n)
 Return a structure used for the preprocessing of ARCqK methods.
 """
-mutable struct PDataLSKARC{T} <: PDataIter{T}
+mutable struct PDataLSKARC{T} <: PDataIterLS{T}
     d::Array{T,1}             # (H+λI)\g ; on first call = g
     λ::T                      # "active" value of λ; on first call = 0
     ζ::T                      # Inexact Newton order parameter: stop when ||∇q|| < ξ * ||g||^(1+ζ)
@@ -144,7 +144,8 @@ end
 function PDataLSKARC(
     ::Type{S},
     ::Type{T},
-    n;
+    n,
+    m;
     ζ = T(0.5),
     ξ = T(0.01),
     maxtol = T(0.01),
@@ -167,9 +168,9 @@ function PDataLSKARC(
     norm_dirs = S(undef, nshifts)
     OK = true
     solver = if solver_method == :cgls
-        CglsLanczosShiftSolver(n, n, nshifts, S)
+        CglsLanczosShiftSolver(m, n, nshifts, S)
     else
-        LsqrShiftSolver(n, n, nshifts, S)
+        LsqrShiftSolver(m, n, nshifts, S)
     end
     return PDataLSKARC(
         d,