Update julia_interface.jl

Author: arnavk23

src/julia_interface.jl

@@ -2,7 +2,6 @@ export cons_coord, cons_coord!, consjac
 
 using NLPModels, SparseArrays
 
-# Type conversion helpers for Issue #392: Preallocate more vectors
 """
     prepare_input!(workspace::Vector{T}, x::AbstractVector{S}) where {T, S}
 
@@ -14,7 +13,7 @@ with converted values if type conversion is required.
 """
 @inline function prepare_input!(workspace::Vector{T}, x::AbstractVector{S}) where {T, S}
   if S === T && typeof(x) <: Vector{T}
-    return x  # No conversion needed
+    return x
   else
     resize!(workspace, length(x))
     workspace .= x
@@ -77,7 +76,6 @@ end
 function NLPModels.grad!(nlp::CUTEstModel{T}, x::AbstractVector, g::AbstractVector) where {T}
   @lencheck nlp.meta.nvar x g
 
-  # Use type conversion helpers to avoid allocations (Issue #392)
   x_prepared = prepare_input!(nlp.input_workspace, x)
 
   if typeof(g) <: Vector{T}
@@ -225,7 +223,6 @@ function cons_coord!(
   @lencheck nlp.meta.ncon c
   @lencheck nlp.meta.nnzj rows cols vals
 
-  # Resize workspace vectors on demand if needed (Issue #392 - double buffering)
   nnzj = nlp.meta.nnzj
   if length(nlp.jac_coord_rows) < nnzj
     resize!(nlp.jac_coord_rows, nnzj)
@@ -236,12 +233,10 @@ function cons_coord!(
     resize!(nlp.cons_vals, nlp.meta.ncon)
   end
 
-  # Use preallocated vectors instead of allocating new ones
   cons_coord!(nlp, Vector{T}(x), view(nlp.cons_vals, 1:nlp.meta.ncon), 
               view(nlp.jac_coord_rows, 1:nnzj), view(nlp.jac_coord_cols, 1:nnzj), 
               view(nlp.jac_coord_vals, 1:nnzj))
 
-  # Copy results to output vectors
   rows .= view(nlp.jac_coord_rows, 1:nnzj)
   cols .= view(nlp.jac_coord_cols, 1:nnzj)
   vals .= view(nlp.jac_coord_vals, 1:nnzj)
@@ -268,7 +263,6 @@ Usage:
 function cons_coord(nlp::CUTEstModel{T}, x::StrideOneVector{T}) where {T}
   @lencheck nlp.meta.nvar x
 
-  # Resize workspace vectors on demand if needed (Issue #392 - double buffering)
   nnzj = nlp.meta.nnzj
   if length(nlp.jac_coord_rows) < nnzj
     resize!(nlp.jac_coord_rows, nnzj)
@@ -279,12 +273,10 @@ function cons_coord(nlp::CUTEstModel{T}, x::StrideOneVector{T}) where {T}
     resize!(nlp.cons_vals, nlp.meta.ncon)
   end
 
-  # Use preallocated vectors to avoid allocations
   cons_coord!(nlp, x, view(nlp.cons_vals, 1:nlp.meta.ncon), 
               view(nlp.jac_coord_rows, 1:nnzj), view(nlp.jac_coord_cols, 1:nnzj), 
               view(nlp.jac_coord_vals, 1:nnzj))
 
-  # Return copies of the results to maintain API compatibility
   c = copy(view(nlp.cons_vals, 1:nlp.meta.ncon))
   rows = copy(view(nlp.jac_coord_rows, 1:nnzj))
   cols = copy(view(nlp.jac_coord_cols, 1:nnzj))