Tron: check and record primal feasibility #356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpo
added a commit
to JuliaSmoothOptimizers/SolverTest.jl
that referenced
this pull request
Jan 28, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to fix issue #355 by ensuring TRON computes and records primal feasibility (bound-constraint violation) in stats.primal_feas / primal residual.
Changes:
- Adds preallocated workspace in
TronSolverto compute primal feasibility. - Computes a primal feasibility norm during initialization and each iteration and writes it into execution stats.
- Updates the termination condition to require both projected-gradient optimality and primal feasibility.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Contributor
|
Contributor
|
dpo
added a commit
to JuliaSmoothOptimizers/SolverTest.jl
that referenced
this pull request
Jan 28, 2026
Contributor
|
Member
Author
|
The failures seem to connected to the pre-release version of Julia. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #355