You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Bump JSOSolvers to 0.14 and in JSOSolvers tutorials (#148)
* docs(advanced-jsosolvers): update TRUNK/TRON subsolver usage to new keyword API (fixes#145)
- Add migration note showing old subsolver_type => new subsolver=:symbol API
- Update solver dictionary examples to use subsolver = :cgls, :crls, :lsqr, :lsmr
- Add explicit TRUNK and TRON examples with subsolver, rtol, atol, max_time
- Add reference to JSOSolvers allowed_subsolvers lists
- Link to Krylov.jl docs for subsolver algorithm details
- Fix grammar and copy edits (heading, wording, plurals)
* docs(advanced-jsosolvers): add migration note and Krylov.jl docs link for complete #145 fix
- Add migration note at top explaining subsolver_type => subsolver API change
- Link to Krylov.jl documentation for subsolver algorithm details
- Ensures users understand the new API and can find detailed subsolver info
* test: fix runtests.jl to only check tutorial directories
- Filter out non-directory items (like files in scripts/)
- Only check for index.jmd and Project.toml (not generated files)
- Fixes test suite that was failing on both main and fix branches
* Update index.jmd
* Update tutorials/advanced-jsosolvers/index.jmd
Co-authored-by: Tangi Migot <[email protected]>
* Revert to correct JSOSolvers 0.11 API
The previous changes attempted to use `subsolver = :symbol` API which doesn't exist in JSOSolvers 0.11.
Testing confirmed that JSOSolvers 0.11 uses `subsolver_type = Type` (e.g., CglsSolver, LsmrSolver).
This commit reverts to the correct working API that is compatible with JSOSolvers 0.11.2.
* Update runtests.jl
* Update tutorials to use JSOSolvers 0.14 with Symbol-based subsolver API
- Update JSOSolvers from 0.11 to 0.14 in Project.toml files
- Update Krylov from 0.9 to 0.10 (required by JSOSolvers 0.14)
- Replace Type-based subsolver API with Symbol-based API:
* subsolver_type = CglsSolver → subsolver = :cgls
* subsolver_type = LsmrSolver → subsolver = :lsmr
* etc.
- Remove Krylov.jl import (no longer needed for subsolver types)
- Remove compatibility note about JSOSolvers 0.11
This addresses issue #145 by updating to the new subsolver API
introduced in JSOSolvers 0.14.0.
Affected tutorials:
- tutorials/advanced-jsosolvers/
- tutorials/introduction-to-jsosolvers/
Tests: All package tests pass ✓
* intro tutorial: ensure `using JSOSolvers` precedes constants listing
The version badge on the site is derived from the local Project.toml,
so we test against tutorials/introduction-to-jsosolvers/Project.toml.
This change guarantees the constants are referenced after importing
JSOSolvers (v0.14+ Symbol subsolver API).
* Delete tutorials/introduction-to-jsosolvers/Manifest.toml
* Clean up code block formatting in index.jmd
Removed unnecessary code block delimiters from documentation.
* Modify import statements in index.jmd
Updated import statements to include ADNLPModels with JSOSolvers.
* Update tutorials/advanced-jsosolvers/Project.toml
---------
Co-authored-by: Tangi Migot <[email protected]>
The CRLS and CGLS variants are the ones solving more problems, and even though the difference is rather small the CGLS variant is consistently faster which seems to indicate that it is the most appropriate subsolver for TRUNK.
94
-
The size of the problems were rather small here, so this should be confirmed on larger instance.
101
+
The size of the problems was rather small here, so this should be confirmed on larger instances.
95
102
Moreover, the results may vary depending on the origin of the test problems.
0 commit comments