Don't export Krylov.solve! (#973)

amontoison · web-flow · commit a3bbee924ddd · 2025-03-21T15:41:59.000-05:00
* Don't export Krylov.solve!

* Update runtests.jl

* Update gpu.jl
diff --git a/src/krylov_solve.jl b/src/krylov_solve.jl
@@ -18,6 +18,7 @@
     solve!(solver, args...; kwargs...)
 
 Generic function that dispatches to the appropriate in-place Krylov method based on the type of `solver`.
+This function is not exported to prevent potential conflicts with other Julia packages.
 """
 function solve! end
 
diff --git a/src/krylov_solvers.jl b/src/krylov_solvers.jl
@@ -5,7 +5,7 @@ BilqSolver, QmrSolver, BilqrSolver, CglsSolver, CglsLanczosShiftSolver, CrlsSolv
 CrmrSolver, LslqSolver, LsqrSolver, LsmrSolver, LnlqSolver, CraigSolver, CraigmrSolver,
 GmresSolver, FomSolver, GpmrSolver, FgmresSolver, CarSolver, MinaresSolver
 
-export solve!, solution, nsolution, statistics, issolved, issolved_primal, issolved_dual,
+export solution, nsolution, statistics, issolved, issolved_primal, issolved_dual,
 niterations, Aprod, Atprod, Bprod, warm_start!
 
 export KrylovConstructor
diff --git a/test/gpu/gpu.jl b/test/gpu/gpu.jl
@@ -1,5 +1,6 @@
 using SparseArrays, Random, Test
 using LinearAlgebra, Krylov, KernelAbstractions
+import Krylov.solve!
 
 if VERSION < v"1.11"
   @kernel function copy_triangle_kernel!(dest, src)
diff --git a/test/runtests.jl b/test/runtests.jl
@@ -1,5 +1,5 @@
 using Krylov, LinearAlgebra, SparseArrays, Printf, Random, Test
-import Krylov.KRYLOV_SOLVERS
+import Krylov: KRYLOV_SOLVERS, solve!
 
 Random.seed!(666)
 
