Fix objcons! for SimpleNLSModel (#507)

* Fix objcons! for SimpleNLSModel to match test expectations: constraints in output, objective from residual

* Add dual objcons! signatures for SimpleNLSModel to support new AbstractNLSModel API

* objcons

* Update src/nls/api.jl

Co-authored-by: Tangi Migot <[email protected]>

* Update src/nls/api.jl

Co-authored-by: Tangi Migot <[email protected]>

* Update simple-model.jl

* changes to the NLS API and a simple model test

* Update src/nls/api.jl

Co-authored-by: Tangi Migot <[email protected]>

* Update src/nls/api.jl

Co-authored-by: Tangi Migot <[email protected]>

* Update test/nls/simple-model.jl

Co-authored-by: Tangi Migot <[email protected]>

---------

Co-authored-by: Tangi Migot <[email protected]>

Author: arnavk23

src/nls/api.jl

@@ -451,6 +451,26 @@ function obj(nls::AbstractNLSModel{T, S}, x::AbstractVector) where {T, S}
   return obj(nls, x, Fx)
 end
 
+"""
+    f, c = objcons!(nls, x, c)
+    f, c = objcons!(nls, x, c, Fx; recompute::Bool=true)
+
+In-place evaluation of constraints and objective for AbstractNLSModel.
+`Fx` is overwritten with the value of the residual `F(x)`.
+If `recompute` is `true`, then `Fx` is updated with the residual at `x`.
+"""
+function objcons!(nls::AbstractNLSModel{T, S}, x::AbstractVector, c::AbstractVector) where {T, S}
+    @lencheck nls.meta.nvar x
+    @lencheck nls.meta.ncon c
+    Fx = S(undef, nls.nls_meta.nequ)
+    return objcons!(nls, x, c, Fx)
+end
+
+function objcons!(nls::AbstractNLSModel, x::AbstractVector, c::AbstractVector, Fx::AbstractVector; recompute::Bool=true)
+  cons_nln!(nls, x, c)
+  return obj(nls, x, Fx; recompute = recompute), c
+end
+
 """
     g = grad!(nls, x, g)
     g = grad!(nls, x, g, Fx; recompute::Bool=true)