Skip to content

Conversation

@arnavk23
Copy link
Contributor

@arnavk23 arnavk23 commented Jul 12, 2025

Closes #400

arnavk23 added 2 commits July 12, 2025 23:35
- Add note about comprehensive counter testing for both direct function calls and sparsity structure-based calls
- Completes issue JuliaSmoothOptimizers#400 implementation with proper documentation
@arnavk23
Copy link
Contributor Author

@amontoison @tmigot All the test pass except upload one

@amontoison
Copy link
Member

@arnavk23 Please tag Tangl for the next two weeks. I am traveling again and will have limited bandwidth.

@tmigot tmigot self-requested a review July 14, 2025 11:23
@arnavk23
Copy link
Contributor Author

@tmigot If you can, please also review this pr as all checks are passing here.

@tmigot
Copy link
Member

tmigot commented Jul 28, 2025

Hi @arnavk23 ! Sorry for the late reply on this one. I actually think we should close the issue and not do anything.
I think your suggestion is ok for this package, but be useful in testing NLPModels in general. Eventually, we could do something in this repo NLPModelsTest.jl, but that's maybe not worth it.

@arnavk23
Copy link
Contributor Author

Sure, @tmigot closing this one then.

@arnavk23 arnavk23 closed this Jul 28, 2025
@arnavk23 arnavk23 deleted the test-counters-jprod-jtprod branch July 28, 2025 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add test for counters of jprod and jtprod using the jacobian sparsity structure

3 participants