-
Notifications
You must be signed in to change notification settings - Fork 37
Add backwards-compat fallbacks for old jac_lin* signatures #515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add backwards-compat fallbacks for old jac_lin* signatures #515
Conversation
|
@amontoison all checks pass. |
|
ref #514 It seems the QuadraticModels tests are still failing with this branch of NLPModels.jl. You can even see it in the (marked passed!) logs of the Breakage test: https://github.com/JuliaSmoothOptimizers/NLPModels.jl/actions/runs/19462261919/job/55689643511?pr=515#step:6:570 EDIT: seems to be due to lack of permissions on that action, so the PR comment never happens for external PRs. not sure if this should be considered a bug? |
As you wrote in |
Breakage always show a success in the Actions whenever they pass. Only the comment in the PR will show the real status. Indeed, we are having a bit of an issue with it right now. There is an issue about that already. |
|
@arnavk23 can you test the unit tests of QuadraticModels with this PR ? We are probably missing @deprecate macros somewhere or got some wrong. |
|
I tried myself and realize we can't really do more. I am closing this and opening a PR to make a new release. |
|
@tmigot Are you also closing the issue or are we letting it stay there. Also can you review my previous prs on this repo. |
In relation with backwards-compat broken by merging of #501.