-
Notifications
You must be signed in to change notification settings - Fork 37
Version 0.22.0 #519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 0.22.0 #519
Conversation
Release notes: ## Breaking changes - drop support for Julia 1.6 - objcons! with in-place residual not defined for NLS - the jac_lin* functions no longer take an x argument.
|
@tmigot You deprecated the old API or is it full breaking? |
|
@frapac We will have more issues with the linear API. |
|
I've been trying to understand the situation here. If I understand well, no package in JSO currently depends on breaking release 0.22 of NLPModels. So nothing is effectively broken as long we don't merge CompatHelper PRs. I propose that we do not bump the dependency of any package (inside our outside jSO) on NLPModels yet. Instead, we should fix what's broken with As a side note, not that many packages depend on the In the future, we should leave PRs that will result in a breaking release open for several days before merging to give everyone a chance to chime in. |
The issue is that we need to update the The last time I did one for In the current situation, since I only need a few non-breaking changes (a new boolean
👍 👍 |
that would complicate things down the line because those commits will later have to be ported to 0.22. In the future, we must be more careful with breaking releases (in any package) but at the moment, the best course of action is to properly deprecate the old API and release 0.22.1. |
|
Yes, but it will take weeks or months until release 0.22 lands in all packages. |
|
No, just the 4 or 5 that use the linear api explicitly. The rest can upgrade at a later time. I think @tmigot is working on a fix now. |
|
No Dominique, we can't have new features of minor modifications until we update the packages for 0.22. |
|
I completely understand and agree that nobody wants this kind of trouble. But the offending commits are already in |
|
It is not an issue if we yank the release 0.22 in the general registry, Dominique :-) If one day we really need a breaking release, we will tag |
This reverts commit c83e702.
This reverts commit c83e702.
Release notes:
Breaking changes