Skip to content

Add ipopt method for AbstractNLSModel #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tmigot merged 24 commits into from
Jul 27, 2025
Merged

Add ipopt method for AbstractNLSModel #132

tmigot merged 24 commits into from
Jul 27, 2025

Conversation

@arnavk23
Copy link
Contributor

@arnavk23 arnavk23 commented Jul 12, 2025 •
edited
Loading

  • Implement ipopt(nls::AbstractNLSModel)
  • Add FeasibilityFormNLS function to convert NLS models for optimization
  • Add comprehensive tests for AbstractNLSModel support
  • Export FeasibilityFormNLS function for user access
  • Using the option print_timing_statistics="yes", Ipopt returns detailed time statistics in the output file that we could parse.

Closes #131

@arnavk23
Add ipopt method for AbstractNLSModel
eacdece 
- Implement ipopt(nls::AbstractNLSModel) as requested in issue JuliaSmoothOptimizers#131
- Add FeasibilityFormNLS function to convert NLS models for optimization
- Add comprehensive tests for AbstractNLSModel support
- Export FeasibilityFormNLS function for user access

Resolves JuliaSmoothOptimizers#131
tmigot
tmigot requested changes Jul 14, 2025
View reviewed changes
Copy link
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arnavk23 for the PR! I made a first round of comments.

@arnavk23
Use FeasibilityFormNLS from NLPModelsModifiers.jl
b5eb23e 
- Remove local FeasibilityFormNLS implementation
- Import FeasibilityFormNLS from NLPModelsModifiers package
- Update tests to work with the external implementation
- Add NLPModelsModifiers to dependencies
@arnavk23 arnavk23 force-pushed the add-abstractnlsmodel-support branch from 1d0fae7 to b5eb23e Compare July 15, 2025 03:53
@arnavk23 arnavk23 requested a review from tmigot July 15, 2025 03:54
tmigot
tmigot requested changes Jul 22, 2025
View reviewed changes
tmigot
tmigot reviewed Jul 22, 2025
View reviewed changes
arnavk23 and others added 2 commits July 22, 2025 19:43
@arnavk23 @tmigot
Update test/runtests.jl
41da9f1 
Co-authored-by: Tangi Migot <[email protected]>
@arnavk23 @tmigot
Update src/NLPModelsIpopt.jl
a785a79 
Co-authored-by: Tangi Migot <[email protected]>
dpo
dpo requested changes Jul 22, 2025
View reviewed changes
@arnavk23 arnavk23 requested review from dpo and tmigot July 22, 2025 20:37
dpo
dpo requested changes Jul 23, 2025
View reviewed changes
@arnavk23 arnavk23 requested a review from dpo July 23, 2025 15:20
dpo
dpo requested changes Jul 23, 2025
View reviewed changes
@arnavk23 arnavk23 requested a review from dpo July 24, 2025 11:02
tmigot
tmigot requested changes Jul 24, 2025
View reviewed changes
Copy link
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the hard work @arnavk23 ! I made some more comments :).

arnavk23 and others added 3 commits July 24, 2025 17:05
tmigot
tmigot reviewed Jul 24, 2025
View reviewed changes
@arnavk23 arnavk23 requested a review from tmigot July 24, 2025 12:09
@arnavk23
Copy link
Contributor Author

arnavk23 commented Jul 25, 2025 •
edited
Loading

@tmigot Passing all now. I think this can be merged now.

tmigot
tmigot requested changes Jul 27, 2025
View reviewed changes
Copy link
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arnavk23 ! I made a final batch of comments and then it will be good to go

@arnavk23 arnavk23 force-pushed the add-abstractnlsmodel-support branch from fe03af9 to 23c0785 Compare July 27, 2025 15:22
@arnavk23 arnavk23 requested a review from tmigot July 27, 2025 15:23
dpo
dpo approved these changes Jul 27, 2025
View reviewed changes
Copy link
Member

@dpo dpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks @arnavk23 !

tmigot
tmigot requested changes Jul 27, 2025
View reviewed changes
arnavk23 and others added 5 commits July 27, 2025 21:22
@arnavk23 @tmigot
Update Project.toml
4dffddf 
Co-authored-by: Tangi Migot <[email protected]>
@arnavk23 @tmigot
Update test/runtests.jl
d5be2b2 
Co-authored-by: Tangi Migot <[email protected]>
@arnavk23 @tmigot
Update test/runtests.jl
a00bea3 
Co-authored-by: Tangi Migot <[email protected]>
@arnavk23 @tmigot
Update test/runtests.jl
c1377ca 
Co-authored-by: Tangi Migot <[email protected]>
@arnavk23 @tmigot
Update test/runtests.jl
e668fec 
Co-authored-by: Tangi Migot <[email protected]>
@arnavk23 arnavk23 requested a review from tmigot July 27, 2025 15:53
tmigot
tmigot reviewed Jul 27, 2025
View reviewed changes
tmigot
tmigot reviewed Jul 27, 2025
View reviewed changes
tmigot
tmigot approved these changes Jul 27, 2025
View reviewed changes
Copy link
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@tmigot tmigot merged commit fb4953f into JuliaSmoothOptimizers:main Jul 27, 2025
12 of 14 checks passed
@arnavk23 arnavk23 deleted the add-abstractnlsmodel-support branch July 27, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dpo dpo dpo approved these changes

@tmigot tmigot tmigot approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Define ipopt(AbstractNLSModel)

3 participants

@arnavk23 @dpo @tmigot