Use NLPModels.@lencheck in cons and residual functions to validate input lengths (#188)

Author: arnavk23

src/moi_nlp_model.jl

@@ -107,12 +107,16 @@ end
 
 function NLPModels.cons_lin!(nlp::MathOptNLPModel, x::AbstractVector, c::AbstractVector)
   increment!(nlp, :neval_cons_lin)
+  NLPModels.@lencheck nlp.meta.nvar x
+  NLPModels.@lencheck nlp.meta.nlin c
   coo_prod!(nlp.lincon.jacobian.rows, nlp.lincon.jacobian.cols, nlp.lincon.jacobian.vals, x, c)
   return c
 end
 
 function NLPModels.cons_nln!(nlp::MathOptNLPModel, x::AbstractVector, c::AbstractVector)
   increment!(nlp, :neval_cons_nln)
+  NLPModels.@lencheck nlp.meta.nvar x
+  NLPModels.@lencheck nlp.meta.nnln c
   if nlp.quadcon.nquad > 0
     for i = 1:(nlp.quadcon.nquad)
       qcon = nlp.quadcon.constraints[i]
@@ -127,6 +131,8 @@ end
 
 function NLPModels.cons!(nlp::MathOptNLPModel, x::AbstractVector, c::AbstractVector)
   increment!(nlp, :neval_cons)
+  NLPModels.@lencheck nlp.meta.nvar x
+  NLPModels.@lencheck nlp.meta.ncon c
   if nlp.meta.nlin > 0
     coo_prod!(nlp.lincon.jacobian.rows, nlp.lincon.jacobian.cols, nlp.lincon.jacobian.vals, x, c)
   end

src/moi_nls_model.jl

@@ -86,6 +86,8 @@ end
 
 function NLPModels.residual!(nls::MathOptNLSModel, x::AbstractVector, Fx::AbstractVector)
   increment!(nls, :neval_residual)
+  NLPModels.@lencheck nls.meta.nvar x
+  NLPModels.@lencheck nls.nls_meta.nequ Fx
   if nls.nls_meta.nlin > 0
     coo_prod!(
       nls.linequ.jacobian.rows,
@@ -253,12 +255,16 @@ end
 
 function NLPModels.cons_lin!(nls::MathOptNLSModel, x::AbstractVector, c::AbstractVector)
   increment!(nls, :neval_cons_lin)
+  NLPModels.@lencheck nls.meta.nvar x
+  NLPModels.@lencheck nls.nls_meta.nlin c
   coo_prod!(nls.lincon.jacobian.rows, nls.lincon.jacobian.cols, nls.lincon.jacobian.vals, x, c)
   return c
 end
 
 function NLPModels.cons_nln!(nls::MathOptNLSModel, x::AbstractVector, c::AbstractVector)
   increment!(nls, :neval_cons_nln)
+  NLPModels.@lencheck nls.meta.nvar x
+  NLPModels.@lencheck nls.meta.nnln c
   if nls.quadcon.nquad > 0
     for i = 1:(nls.quadcon.nquad)
       qcon = nls.quadcon.constraints[i]
@@ -273,6 +279,8 @@ end
 
 function NLPModels.cons!(nls::MathOptNLSModel, x::AbstractVector, c::AbstractVector)
   increment!(nls, :neval_cons)
+  NLPModels.@lencheck nls.meta.nvar x
+  NLPModels.@lencheck nls.meta.ncon c
   if nls.meta.nlin > 0
     coo_prod!(nls.lincon.jacobian.rows, nls.lincon.jacobian.cols, nls.lincon.jacobian.vals, x, c)
   end

test/lencheck.jl

@@ -0,0 +1,9 @@
+using Test
+using NLPModelsJuMP
+
+@testset "lencheck macro" begin
+    x = [1,2,3]
+    NLPModels.@lencheck 3 x
+    y = [1,2]
+    @test_throws ArgumentError NLPModels.@lencheck 3 y
+end