Skip to content

Support MOI.VectorNonlinearOracle #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
amontoison merged 19 commits into from
Dec 22, 2025
Merged

Support MOI.VectorNonlinearOracle #218

amontoison merged 19 commits into from
Dec 22, 2025

Conversation

@amontoison
Copy link
Member

@amontoison amontoison commented Dec 12, 2025 •
edited
Loading

close #219
#217

@andrewrosemberg
Andrew, can you continue this PR?

I started the support of oracles in MathOptNLPModel but it is not finished.
We need to also support it in MathOptNLSModel and add unit tests.

@amontoison amontoison self-assigned this Dec 12, 2025
@amontoison amontoison added the enhancement New feature or request label Dec 12, 2025
@andrewrosemberg andrewrosemberg mentioned this pull request Dec 12, 2025
Merged
andrewrosemberg
andrewrosemberg reviewed Dec 12, 2025
View reviewed changes
@andrewrosemberg andrewrosemberg mentioned this pull request Dec 16, 2025
Merged
@amontoison
Copy link
Member Author

amontoison commented Dec 18, 2025

@andrewrosemberg Is the ready for a review?
I very quickly have a look and I suggest to rename oracles_data / OraclesData into oracles / Oracles.

Were you able to solve you JuMP model with an oracle with Ipopt to test it?

@andrewrosemberg
Copy link
Collaborator

andrewrosemberg commented Dec 18, 2025

@andrewrosemberg Is the ready for a review? I very quickly have a look and I suggest to rename oracles_data / OraclesData into oracles / Oracles.

Were you able to solve you JuMP model with an oracle with Ipopt to test it?

found a bug when testing the hessian that I am trying to figure out: amontoison#5

@andrewrosemberg
More nlp tests [WIP] (#5)
1c9cadd 
* hs10 oracle tests

* add hs14_oracle

* normalize constraints test

* add more tests nlp

* start checking jacobian and hessian

* fix bug hessian

* fix bg consistency
@amontoison amontoison mentioned this pull request Dec 18, 2025
Closed
@amontoison amontoison marked this pull request as ready for review December 19, 2025 01:34
@amontoison
Copy link
Member Author

amontoison commented Dec 19, 2025

@andrewrosemberg I did a full pass on your modifications.
Can you review my commit: 345b20e
I found a few issues with the offset for the sparse Jacobian, you forgot to add the offset related to nlp.nlcon for the constraints in the oracle.
We still need to fix the unit tests but it should not be hard now.

andrewrosemberg
andrewrosemberg reviewed Dec 22, 2025
View reviewed changes
andrewrosemberg
andrewrosemberg approved these changes Dec 22, 2025
View reviewed changes
Copy link
Collaborator

@andrewrosemberg andrewrosemberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amontoison amontoison merged commit ca059cc into JuliaSmoothOptimizers:main Dec 22, 2025
13 of 14 checks passed
@amontoison amontoison deleted the am/oracle branch December 22, 2025 02:08
@amontoison amontoison mentioned this pull request Dec 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewrosemberg andrewrosemberg andrewrosemberg approved these changes

Assignees

@amontoison amontoison

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add nl_lcon and nl_ucon in NonLinearStructure

2 participants

@amontoison @andrewrosemberg