Update names of `errinros_mod`, `chnrosnb_mod` and `fletcbv3_mod`?

[danphenderson]

The current names of these ADNLPModels are errinros, chnrosnb and fletcbv3; respectively.

In my use case, I am instantiating a set of ADNLPModels from a list of their names; but I run into issues with these models as their names do not correspond to the name of the file in the source code.

A fix would be to update these model's names to errinros_mod, chnrosnb_mod and fletcbv3_mod.

[danphenderson]

Also, indef_mod.

[tmigot]

Thanks @danphenderson for the issue. You are right, bwe should modify the problems' names.

For errinros_mod:

OptimizationProblems.jl/src/ADNLPProblems/errinros_mod.jl

Line 21 in f563bb6

return ADNLPModels.ADNLPModel(f, x0, name = "errinros"; kwargs...)

and also the NLS variant:

OptimizationProblems.jl/src/ADNLPProblems/errinros_mod.jl

Line 40 in f563bb6

return ADNLPModels.ADNLSModel!(F!, x0, 2 * (n - 1), name = "errinros-nls"; kwargs...)

This could also be tested, probably here:

OptimizationProblems.jl/test/runtests.jl

Line 29 in f563bb6

@test nlp_ad.meta.name == String(pb)

strangely enough the name was correct in the dataframe describing the problems

OptimizationProblems.jl/src/Meta/errinros_mod.jl

Line 7 in f563bb6

:name => "errinros_mod",

@danphenderson Would you be interested in opening a PR to fix this?

[danphenderson]

@tmigot, thanks for the additional instructions - PR submitted.