-
Notifications
You must be signed in to change notification settings - Fork 48
Update compat versions for DataFrames and JLD2 #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update compat versions for DataFrames and JLD2 #371
Conversation
Changed the compatibility entries for DataFrames and JLD2 to use caret (^) syntax, allowing for more flexible version resolution.
|
@dpo I think this will fix this as well JuliaSmoothOptimizers/BundleAdjustmentModels.jl#106 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #371 +/- ##
=======================================
Coverage 99.80% 99.80%
=======================================
Files 1084 1084
Lines 12319 12321 +2
=======================================
+ Hits 12295 12297 +2
Misses 24 24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Dominique <[email protected]>
|
@tmigot , they used it here
|
|
Would be nice to have a release for the bump of JLD2 compat, as it currently holds back testing of SparseConnectivityTracer on Julia 1.12, see adrhill/SparseConnectivityTracer.jl#246. JLD2 just released JLD2 = "0.4, 0.5, 0.6"As a side note, caret syntax is the default behavior of Pkg and therefore not "more flexible": https://pkgdocs.julialang.org/v1/compatibility/#Caret-specifiers CC @amontoison |
| [compat] | ||
| DataFrames = "1" | ||
| JLD2 = "0.4" | ||
| DataFrames = "^1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| DataFrames = "^1" | |
| DataFrames = "1" |
| DataFrames = "1" | ||
| JLD2 = "0.4" | ||
| DataFrames = "^1" | ||
| JLD2 = "0.4, 0.5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| JLD2 = "0.4, 0.5" | |
| JLD2 = "0.4, 0.5, 0.6" |
|
@adrhill I suggested the modifications to @farhadrclass. |
|
Thanks a lot @farhadrclass @amontoison! |
Changed the compatibility entries for
DataFramesandJLD2inProject.tomlto use caret (^) syntax. This allows for more flexible version resolution within the same major version, reducing potential package conflicts and improving compatibility with other dependencies.Changes:
DataFrames = "1"→DataFrames = "^1"JLD2 = "0.4"→JLD2 = "^0.5"This update ensures the package works smoothly with newer patch and minor releases of these dependencies.