Skip to content

Conversation

@farhadrclass
Copy link
Contributor

Changed the compatibility entries for DataFrames and JLD2 in Project.toml to use caret (^) syntax. This allows for more flexible version resolution within the same major version, reducing potential package conflicts and improving compatibility with other dependencies.

Changes:

  • DataFrames = "1"DataFrames = "^1"
  • JLD2 = "0.4"JLD2 = "^0.5"

This update ensures the package works smoothly with newer patch and minor releases of these dependencies.

Changed the compatibility entries for DataFrames and JLD2 to use caret (^) syntax, allowing for more flexible version resolution.
@farhadrclass
Copy link
Contributor Author

@dpo I think this will fix this as well JuliaSmoothOptimizers/BundleAdjustmentModels.jl#106

@codecov
Copy link

codecov bot commented Aug 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.80%. Comparing base (2ada450) to head (9c700dd).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #371   +/-   ##
=======================================
  Coverage   99.80%   99.80%           
=======================================
  Files        1084     1084           
  Lines       12319    12321    +2     
=======================================
+ Hits        12295    12297    +2     
  Misses         24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: Dominique <[email protected]>
@farhadrclass
Copy link
Contributor Author

@tmigot , they used it here

@save "data_tetra_duct12.jld2" xe_duct12 TETS_duct12 Const_duct12

@adrhill
Copy link

adrhill commented Aug 25, 2025

Would be nice to have a release for the bump of JLD2 compat, as it currently holds back testing of SparseConnectivityTracer on Julia 1.12, see adrhill/SparseConnectivityTracer.jl#246.

JLD2 just released v0.6.0, so you might want to add

JLD2 = "0.4, 0.5, 0.6"

As a side note, caret syntax is the default behavior of Pkg and therefore not "more flexible": https://pkgdocs.julialang.org/v1/compatibility/#Caret-specifiers

CC @amontoison

[compat]
DataFrames = "1"
JLD2 = "0.4"
DataFrames = "^1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
DataFrames = "^1"
DataFrames = "1"

DataFrames = "1"
JLD2 = "0.4"
DataFrames = "^1"
JLD2 = "0.4, 0.5"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
JLD2 = "0.4, 0.5"
JLD2 = "0.4, 0.5, 0.6"

@amontoison
Copy link
Member

@adrhill I suggested the modifications to @farhadrclass.
If all tests passed, I will merge and tag a new release.

@amontoison amontoison merged commit 1a874c4 into JuliaSmoothOptimizers:main Aug 26, 2025
18 checks passed
@adrhill
Copy link

adrhill commented Aug 26, 2025

Thanks a lot @farhadrclass @amontoison!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants