complete API

Author: tmigot

src/qpmodel.jl

@@ -385,7 +385,7 @@ function NLPModels.jac_lin_structure!(
   return rows, cols
 end
 
-function NLPModels.jac_structure!(
+function NLPModels.jac_lin_structure!(
   qp::QuadraticModel{T, S, M1, M2},
   rows::AbstractVector{<:Integer},
   cols::AbstractVector{<:Integer},
@@ -503,6 +503,19 @@ function NLPModels.jtprod!(
   x::AbstractVector,
   v::AbstractVector,
   Atv::AbstractVector,
+)
+  @lencheck qp.meta.nvar x Atv
+  @lencheck qp.meta.ncon v
+  NLPModels.increment!(qp, :neval_jtprod)
+  mul!(Atv, transpose(qp.data.A), v)
+  return Atv
+end
+
+function NLPModels.jtprod_lin!(
+  qp::AbstractQuadraticModel,
+  x::AbstractVector,
+  v::AbstractVector,
+  Atv::AbstractVector,
 )
   @lencheck qp.meta.nvar x Atv
   @lencheck qp.meta.nlin v

test/problems/eqconqp.jl

@@ -3,11 +3,11 @@ function eqconqp_autodiff()
   n = 50
   x0 = zeros(n)
   f(x) = sum(i * x[i]^2 for i = 1:n) / 2 + x[1] * x[n]
-  c(x) = [sum(x) - 1.0]
-  lcon = [0.0]
-  ucon = [0.0]
+  lcon = [1.0]
+  ucon = [1.0]
+  A = ones(1, n)
 
-  return ADNLPModel(f, x0, c, lcon, ucon, name = "eqconqp_autodiff")
+  return ADNLPModel(f, x0, sparse(A), lcon, ucon, name = "eqconqp_autodiff")
 end
 
 function eqconqp_QP_dense()

test/problems/ineqconqp.jl

@@ -2,11 +2,14 @@
 function ineqconqp_autodiff()
   x0 = ones(2)
   f(x) = (x[1] - 1)^2 / 2 + (x[2] - 1)^2 / 2
-  c(x) = [x[1] - x[2]; x[2] - x[1]; x[1] + x[2]]
   lcon = [0.0; -Inf; -1.0]
   ucon = [Inf; 0.0; 1.0]
 
-  return ADNLPModel(f, x0, c, lcon, ucon, name = "ineqconqp_autodiff")
+  Arows = [1, 1, 2, 2, 3, 3]
+  Acols = [1, 2, 1, 2, 1, 2]
+  Avals = [1.0; -1.0; -1.0; 1.0; 1.0; 1.0]
+
+  return ADNLPModel(f, x0, Arows, Acols, Avals, lcon, ucon, name = "ineqconqp_autodiff")
 end
 
 function ineqconqp_QP()

test/test_consistency.jl

@@ -65,7 +65,7 @@ for problem in NLPModelsTest.nlp_problems
         zeros(nlp.meta.nvar),
         nlp.meta.lvar - x,
         nlp.meta.uvar - x,
-        s -> Ax * s,
+        Ax,
         nlp.meta.lcon - cx,
         nlp.meta.ucon - cx,
       )