Skip to content

Set meta.islp based on nnzh #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2025
Merged

Set meta.islp based on nnzh #161

merged 1 commit into from
Sep 21, 2025

Conversation

klamike
Copy link
Contributor

@klamike klamike commented Sep 20, 2025

Closes #160

@klamike
Copy link
Contributor Author

klamike commented Sep 20, 2025

Just noticed there is #149 which actually includes this fix as well as a bunch of other nice features for the LP case.. maybe it would be better to get that PR merged? @amontoison what do you think, anything I can do to help there?

tmigot
tmigot approved these changes Sep 21, 2025
View reviewed changes
Copy link
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @klamike for the PR!
It would be good to have #149 as well, I suggest to move the discussions up there.
Do you need a new release of the package with this fix?

@tmigot tmigot merged commit 340677e into JuliaSmoothOptimizers:main Sep 21, 2025
30 of 31 checks passed
@klamike
Copy link
Contributor Author

klamike commented Sep 21, 2025

Thanks @tmigot :) No need for a new release, it can wait if you like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmigot tmigot tmigot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent NLPModelsMeta.islp
2 participants
@klamike @tmigot