Update RegularizedOptimization.jl and utils.jl

Use alphabetical order for external dependencies and remove unused variables.

Author: MohamedLaghdafHABIBOULLAH

src/RegularizedOptimization.jl

@@ -4,7 +4,7 @@ module RegularizedOptimization
 using LinearAlgebra, Logging, Printf
 
 # external dependencies
-using ProximalOperators, Arpack
+using Arpack, ProximalOperators
 
 # dependencies from us
 using LinearOperators,

src/utils.jl

@@ -8,7 +8,6 @@ function opnorm_eig(B; max_attempts::Int = 3)
   have_eig = false
   attempt = 0
   λ = zero(eltype(B))
-  success = false
   n = size(B, 1)
   nev = 1
   ncv = max(20, 2 * nev + 1)
@@ -18,19 +17,17 @@ function opnorm_eig(B; max_attempts::Int = 3)
     have_eig = nconv == 1
     if (have_eig)
       λ = abs(d[1])
-      success = true
     else
       ncv = min(2 * ncv, n)
     end
   end
-  return λ, success
+  return λ, have_eig
 end
 
 function opnorm_svd(J; max_attempts::Int = 3)
   have_svd = false
   attempt = 0
   σ = zero(eltype(J))
-  success = false
   n = min(size(J)...)
   nsv = 1
   ncv = 10
@@ -40,12 +37,11 @@ function opnorm_svd(J; max_attempts::Int = 3)
     have_svd = nconv == 1
     if (have_svd)
       σ = maximum(s.S)
-      success = true
     else
       ncv = min(2 * ncv, n)
     end
   end
-  return σ, success
+  return σ, have_svd
 end
 
 ShiftedProximalOperators.iprox!(