Fix pre review comments #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxenceGollier
commented
Oct 16, 2025
dpo
requested changes
Oct 16, 2025
Member
dpo
left a comment
dpo
left a comment
There was a problem hiding this comment.
Voici une 1e ronde de commentaire.
SVP nous dire combien il y a de mots.
Collaborator
Author
|
@dpo I added a workflow, we have 1096 words currently. |
dpo
requested changes
Oct 17, 2025
MohamedLaghdafHABIBOULLAH
approved these changes
Oct 20, 2025
dpo
requested changes
Oct 21, 2025
|
|
||
| - **SVM with $\ell^{1/2}$ penalty:** **R2N** is the fastest, requiring the fewest gradient evaluations compared to all the other solvers. | ||
| **R2N** is the fastest, requiring the fewest gradient evaluations. | ||
| However, it requires more proximal evaluations, but these are inexpensive. |
Member
There was a problem hiding this comment.
Il me semble qu'il y a un bug quelque part car le nombre de prox diffère d'un ordre de grandeur !
Co-authored-by: Dominique <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.