Fix the issue with reset! (#242)

Author: amontoison

.cirrus.yml

@@ -1,5 +1,5 @@
 freebsd_instance:
-  image_family: freebsd-13-3
+  image_family: freebsd-14-2
 task:
   name: FreeBSD
   env:

.github/workflows/Breakage.yml

@@ -159,7 +159,49 @@ jobs:
             fi
           done >> summary.md
 
+      - name: Display summary in CI logs
+        run: |
+          echo "### Breakage Summary" >> $GITHUB_STEP_SUMMARY
+          cat breakage/summary.md >> $GITHUB_STEP_SUMMARY
+
       - name: PR comment with file
-        uses: thollander/actions-comment-pull-request@v2
+        if: github.event.pull_request.head.repo.fork == false
+        uses: actions/github-script@main
         with:
-          filePath: breakage/summary.md
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          script: |
+            // Import file content from summary.md
+            const fs = require('fs')
+            const filePath = 'breakage/summary.md'
+            const msg = fs.readFileSync(filePath, 'utf8')
+
+            // Get the current PR number from context
+            const prNumber = context.payload.pull_request.number
+
+            // Fetch existing comments on the PR
+            const { data: comments } = await github.rest.issues.listComments({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              issue_number: prNumber
+            })
+
+            // Find a previous comment by the bot to update
+            const botComment = comments.find(comment => comment.user.id === 41898282)
+
+            if (botComment) {
+              // Update the existing comment
+              await github.rest.issues.updateComment({
+                owner: context.repo.owner,
+                repo: context.repo.repo,
+                comment_id: botComment.id,
+                body: msg
+              })
+            } else {
+              // Create a new comment
+              await github.rest.issues.createComment({
+                owner: context.repo.owner,
+                repo: context.repo.repo,
+                issue_number: prNumber,
+                body: msg
+              })
+            }

.github/workflows/Test.yml

@@ -26,23 +26,22 @@ jobs:
           - "1"
         os:
           - ubuntu-latest
-          - macOS-latest
-          
+          - maos-latest
           - windows-latest
 
         arch:
           - x64
         allow_failure: [false]
         include:
-          - version: "nightly"
+          - version: "pre"
             os: ubuntu-latest
             arch: x64
             allow_failure: true
-          - version: "nightly"
-            os: macOS-latest
+          - version: "pre"
+            os: macos-latest
             arch: x64
             allow_failure: true
-          - version: "nightly"
+          - version: "pre"
             os: windows-latest
             arch: x64
             allow_failure: true

Project.toml

@@ -9,6 +9,8 @@ NLPModels = "a4795742-8479-5a88-8948-cc11e1c8c1a6"
 Printf = "de0858da-6303-5e67-8744-51eddeeeb8d7"
 
 [compat]
+LinearAlgebra = "1.10"
 LinearOperators = "2.0"
 NLPModels = "0.21"
-julia = "^1.10"
+Printf = "1.10"
+julia = "1.10"

src/trust-region/trust-region.jl

@@ -1,5 +1,4 @@
 # A trust-region type and basic utility functions.
-import NLPModels: reset!
 export TrustRegionException, acceptable, aredpred!, reset!, update!
 
 "Exception type raised in case of error."
@@ -170,7 +169,7 @@ end
 
 Reset the trust-region radius to its initial value.
 """
-function reset!(tr::AbstractTrustRegion)
+function NLPModels.reset!(tr::AbstractTrustRegion)
   tr.radius = tr.initial_radius
   return tr
 end

test/test-trust_region.jl

@@ -98,11 +98,11 @@ end
     tr.ratio = T(10)
     update!(tr, Δ₀)
     @test tr.radius > Δ₀
-    reset!(tr)
+    NLPModels.reset!(tr)
     tr.ratio = -T(1)
     update!(tr, Δ₀)
     @test tr.radius < Δ₀
-    reset!(tr)
+    NLPModels.reset!(tr)
 
     if VERSION ≥ v"1.7"
       trust_region_allocs_test(TrustRegion, S)
@@ -120,15 +120,15 @@ end
     tr.ratio = tr.acceptance_threshold - 1
     update!(tr, Δ₀)
     @test tr.radius < Δ₀
-    reset!(tr)
+    NLPModels.reset!(tr)
     tr.ratio = (tr.acceptance_threshold + tr.decrease_threshold) / 2
     update!(tr, Δ₀)
     @test tr.radius < Δ₀
-    reset!(tr)
+    NLPModels.reset!(tr)
     tr.ratio = (tr.decrease_threshold + tr.increase_threshold) / 2
     update!(tr, Δ₀)
     @test tr.radius < Δ₀
-    reset!(tr)
+    NLPModels.reset!(tr)
     tr.ratio = tr.increase_threshold + 1
     tr.quad_min = T(2)
     update!(tr, Δ₀)