Fix compat. Allow newer Aqua. Only run Aqua on repo tests. (#471)

* fix compat. Allow newer Aqua

* rm removed Aqua test

* only run aqua stuff on repo CI

(cherry picked from commit f154de2)

Author: IanButterworth

.github/workflows/ci.yml

@@ -52,6 +52,8 @@ jobs:
       - run: julia --color=yes .ci/test_and_change_uuid.jl
       - uses: julia-actions/julia-buildpkg@v1
       - uses: julia-actions/julia-runtest@v1
+        env:
+          SPARSEARRAYS_AQUA_TEST: true
       - uses: julia-actions/julia-processcoverage@v1
       - uses: codecov/codecov-action@v1
         with:

Project.toml

@@ -10,8 +10,17 @@ Serialization = "9e88b42a-f829-5b0c-bbe9-9e923198166b"
 SuiteSparse_jll = "bea87d4a-7f5b-5778-9afe-8cc45184846c"
 
 [compat]
-Aqua = "0.7"
+Aqua = "0.7, 0.8"
+Dates = "<0.0.1, 1"
+InteractiveUtils = "<0.0.1, 1"
+Libdl = "<0.0.1, 1"
+LinearAlgebra = "<0.0.1, 1"
+Pkg = "<0.0.1, 1"
+Printf = "<0.0.1, 1"
+Random = "<0.0.1, 1"
+Serialization = "<0.0.1, 1"
 SuiteSparse_jll = "7.2.1"
+Test = "<0.0.1, 1"
 julia = "1.10"
 
 [extras]

test/ambiguous.jl

@@ -14,7 +14,9 @@ if Base.find_package("Aqua") === nothing
     @debug "Installing Aqua.jl for SparseArrays.jl tests"
     iob = IOBuffer()
     try
-        Pkg.add("Aqua", io=iob) # Needed for custom julia version resolve tests
+        # TODO: make this version tie to compat in Project.toml
+        # or do this another safer way
+        Pkg.add(name="Aqua", version="0.8", io=iob) # Needed for custom julia version resolve tests
     catch
         println(String(take!(iob)))
         rethrow()
@@ -42,9 +44,7 @@ using Test, LinearAlgebra, SparseArrays, Aqua
     @testset "Compat bounds" begin
         Aqua.test_deps_compat(SparseArrays)
     end
-    @testset "Project.toml formatting" begin
-        Aqua.test_project_toml_formatting(SparseArrays)
-    end
+
     @testset "Piracy" begin
         @test_broken Aqua.Piracy.hunt(SparseArrays) == Method[]
     end

test/runtests.jl

@@ -1,6 +1,10 @@
 # This file is a part of Julia. License is MIT: https://julialang.org/license
 using Test, LinearAlgebra, SparseArrays
 
+if Base.get_bool_env("SPARSEARRAYS_AQUA_TEST", false)
+    include("ambiguous.jl")
+end
+
 for file in readlines(joinpath(@__DIR__, "testgroups"))
     file == "" && continue # skip empty lines
     include(file * ".jl")

test/testgroups

@@ -1,5 +1,4 @@
 allowscalar
-ambiguous
 cholmod
 fixed
 higherorderfns