Set types by SparseMatrixCSC{Tv, Ti} when possible

Author: pawel-tarasiuk-quantumz

src/solvers/spqr.jl

@@ -204,10 +204,10 @@ function LinearAlgebra.qr(A::SparseMatrixCSC{Tv, Ti}; tol=_default_tol(A), order
         C_NULL, C_NULL, C_NULL, C_NULL,
         R, E, H, HPinv, HTau)
 
-    R_ = SparseMatrixCSC(Tv.(Sparse(R[])))
-    return QRSparse(SparseMatrixCSC(Tv.(Sparse(H[]))),
+    R_ = SparseMatrixCSC{Tv, Ti}(Sparse(R[]))
+    return QRSparse(SparseMatrixCSC{Tv, Ti}(Tv.(Sparse(H[]))),
                     vec(Array{Tv}(CHOLMOD.Dense(HTau[]))),
-                    SparseMatrixCSC(min(size(A)...),
+                    SparseMatrixCSC{Tv, Ti}(min(size(A)...),
                                     size(R_, 2),
                                     getcolptr(R_),
                                     rowvals(R_),

test/spqr.jl

@@ -110,6 +110,12 @@ end
     @test (F.Q*F.R)::SparseMatrixCSC == A[F.prow,F.pcol]
 end
 
+@testset "Issue #585 for element type: $eltyA" for eltyA in (Float64, Float32)
+    A = sparse(eltyA[1 0; 0 1])
+    F = qr(A)
+    @test eltype(F.Q) == eltype(F.R) == eltyA
+end
+
 @testset "select ordering overdetermined" begin
      A = sparse([1:n; rand(1:m, nn - n)], [1:n; rand(1:n, nn - n)], randn(nn), m, n)
      b = randn(m)