Add bounds checks to inplace kron! (#330)

Author: dkarrasch

src/linalg.jl

@@ -1318,7 +1318,8 @@ end
 @inline function kron!(C::SparseMatrixCSC, A::AbstractSparseMatrixCSC, B::AbstractSparseMatrixCSC)
     mA, nA = size(A); mB, nB = size(B)
     mC, nC = mA*mB, nA*nB
-
+    @boundscheck size(C) == (mC, nC) || throw(DimensionMismatch("target matrix needs to have size ($mC, $nC)," * 
+        " but has size $(size(C))"))
     rowvalC = rowvals(C)
     nzvalC = nonzeros(C)
     colptrC = getcolptr(C)
@@ -1362,6 +1363,8 @@ end
     return kron!(C, copy(A), copy(B))
 end
 @inline function kron!(z::SparseVector, x::SparseVector, y::SparseVector)
+    @boundscheck length(z) == length(x)*length(y) || throw(DimensionMismatch("length of " *
+        "target vector needs to be $(length(x)*length(y)), but has length $(length(z))"))
     nnzx = nnz(x); nnzy = nnz(y);
     nzind = nonzeroinds(z)
     nzval = nonzeros(z)

test/linalg.jl

@@ -754,6 +754,10 @@ end
         @test Vector(kron(x, z)) == kron(x_d, z_d)
         @test Array(kron(a, z)) == kron(a_d, z_d)
         @test Array(kron(z, b)) == kron(z_d, b_d)
+        # test bounds checks
+        @test_throws DimensionMismatch kron!(copy(a), a, b)
+        @test_throws DimensionMismatch kron!(copy(x), x, y)
+        @test_throws DimensionMismatch kron!(spzeros(2,2), x, y')
     end
 end