QR: handle xtype/dtype other than input Tv

Author: pawel-tarasiuk-quantumz

src/solvers/cholmod.jl

@@ -901,6 +901,15 @@ Dense(A::StridedVecOrMatInclAdjAndTrans{T}) where
 
 Dense(A::Sparse) = sparse_to_dense(A)
 
+function Dense(ptr::Ptr{cholmod_dense})
+    if ptr == C_NULL
+        throw(ArgumentError("dense matrix construction failed for " *
+            "unknown reasons. Please submit a bug report."))
+    end
+    s = unsafe_load(ptr)
+    return Dense{jlxtype(s.xtype, s.dtype)}(ptr)
+end
+
 function Base.convert(::Type{Dense{Tnew}}, A::Dense{T}) where {Tnew, T}
     GC.@preserve A begin
         Ap = unsafe_load(pointer(A))

src/solvers/spqr.jl

@@ -204,9 +204,9 @@ function LinearAlgebra.qr(A::SparseMatrixCSC{Tv, Ti}; tol=_default_tol(A), order
         C_NULL, C_NULL, C_NULL, C_NULL,
         R, E, H, HPinv, HTau)
 
-    R_ = SparseMatrixCSC(Sparse(R[]))
-    return QRSparse(SparseMatrixCSC(Sparse(H[])),
-                    vec(Array(CHOLMOD.Dense{Tv}(HTau[]))),
+    R_ = SparseMatrixCSC(Tv.(Sparse(R[])))
+    return QRSparse(SparseMatrixCSC(Tv.(Sparse(H[]))),
+                    vec(Array{Tv}(CHOLMOD.Dense(HTau[]))),
                     SparseMatrixCSC(min(size(A)...),
                                     size(R_, 2),
                                     getcolptr(R_),