Skip to content

Commit ee419ae

Browse files
authored
Re-enable the METIS ordering tests (#371)
1 parent a2e9a88 commit ee419ae

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

test/spqr.jl

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -109,9 +109,7 @@ end
109109
A = sparse([1:n; rand(1:m, nn - n)], [1:n; rand(1:n, nn - n)], randn(nn), m, n)
110110
b = randn(m)
111111
xref = Array(A) \ b
112-
# Filter out METIS ordering. https://github.com/JuliaSparse/SparseArrays.jl/issues/369
113-
spqr_orderings = filter(x->x!=6, SPQR.ORDERINGS)
114-
for ordering spqr_orderings
112+
for ordering SPQR.ORDERINGS
115113
QR = qr(A, ordering=ordering)
116114
x = QR \ b
117115
@test x xref
@@ -122,9 +120,7 @@ end
122120
@testset "select ordering underdetermined" begin
123121
A = sparse([1:n; rand(1:n, nn - n)], [1:n; rand(1:m, nn - n)], randn(nn), n, m)
124122
b = A * ones(m)
125-
# Filter out METIS ordering. https://github.com/JuliaSparse/SparseArrays.jl/issues/369
126-
spqr_orderings = filter(x->x!=6, SPQR.ORDERINGS)
127-
for ordering spqr_orderings
123+
for ordering SPQR.ORDERINGS
128124
QR = qr(A, ordering=ordering)
129125
x = QR \ b
130126
# x ≂̸ Array(A) \ b; LAPACK returns a min-norm x while SPQR returns a basic x

0 commit comments

Comments
 (0)