Fix the ambiguities method issue for Factor (#27)

* Fix ambiguous method issue for `Factor`

* Add test for `detect_ambiguities`

Author: Gnimuc

src/cholmod.jl

@@ -336,8 +336,6 @@ mutable struct Factor{Tv<:VTypes} <: Factorization{Tv}
         return F
     end
 end
-Factor(ptr::Ptr{cholmod_factor}) where {Tv<:VTypes} = Factor{Tv}(ptr)
-Factor(x::Factor) = x
 
 Base.adjoint(F::Factor) = Adjoint(F)
 Base.transpose(F::Factor) = Transpose(F)
@@ -384,7 +382,7 @@ function FactorComponent(F::Factor{Tv}, sym::Symbol) where Tv
     FactorComponent{Tv,sym}(F)
 end
 
-Factor(FC::FactorComponent) = Factor(FC.F)
+Factor(FC::FactorComponent) = FC.F
 
 #################
 # Thin wrappers #

test/ambiguous.jl

@@ -0,0 +1,6 @@
+using SuiteSparse
+using Test
+
+@testset "detect_ambiguities" begin
+    @test_nowarn detect_ambiguities(SuiteSparse; recursive=true, ambiguous_bottom=false)
+end

test/runtests.jl

@@ -4,6 +4,7 @@ using Test, Random
 using SuiteSparse, LinearAlgebra, SparseArrays
 
 if Base.USE_GPL_LIBS
+    include("ambiguous.jl")
     include("umfpack.jl")
     include("cholmod.jl")
     include("spqr.jl")