new storageorder impl

Author: rayegun

src/oriented.jl

@@ -1,5 +1,4 @@
-StorageOrders.storageorder(::OrientedGBMatrix{T, F, O}) where {T, F, O} = O
-
+StorageOrders.comptime_storageorder(::OrientedGBMatrix{T, F, O}) where {T, F, O} = O
 function GBMatrixC{T, F}(
     A::SparseVector; 
     fill = defaultfill(F)

src/shallowtypes.jl

@@ -1,7 +1,5 @@
 # fall back to nzval, this may need to change eventually, as it's currently not possible to know the storage order.
 # Either a new parameter or something else.
-StorageOrders.storageorder(A::AbstractGBShallowArray) = storageorder(A.nzval)
-
 function GBShallowVector(v::DenseVector{T}; fill::F = nothing) where {T, F}
     m = _newGrBRef()
     @wraperror LibGraphBLAS.GrB_Matrix_new(m, gbtype(T), size(v, 1), size(v, 2))

src/types.jl

@@ -720,7 +720,6 @@ GBVector{T}(
     fill::F = defaultfill(T)
 ) where {T, F} = return GBVector{T, F}(p; fill)
 
-StorageOrders.storageorder(::GBVector) = ColMajor()
 # we call @gbvectortype GBVector below GBMatrix defn.
 
 """
@@ -830,7 +829,8 @@ end
 
 # We need to do this at runtime. This should perhaps be `RuntimeOrder`, but that trait should likely be removed.
 # This should ideally work out fine. a GBMatrix or GBVector won't have 
-StorageOrders.storageorder(A::AbstractGBMatrix) = gbget(A, :format) == Integer(BYCOL) ? StorageOrders.ColMajor() : StorageOrders.RowMajor()
+StorageOrders.runtime_storageorder(A::AbstractGBMatrix) = gbget(A, :format) == Integer(BYCOL) ? StorageOrders.ColMajor() : StorageOrders.RowMajor()
+StorageOrders.comptime_storageorder(::AbstractGBMatrix) = StorageOrders.RuntimeOrder()
 StorageOrders.storageorder(::AbstractGBVector) = ColMajor()
 
 defaultfill(::Type{T}) where T = zero(T)