Skip to content

Commit 76c1b69

Browse files
committed
rm use of Nothing as fill, we want to use Missing
1 parent 53f853c commit 76c1b69

File tree

2 files changed

+2
-13
lines changed

2 files changed

+2
-13
lines changed

src/operations/operationutils.jl

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -110,16 +110,9 @@ Determine type of the output of a typed operator.
110110
"""
111111
function ztype end
112112

113-
_promotefill(::AbstractGBArray{<:Any, Nothing}, ::AbstractGBArray{<:Any, Nothing}, op) = nothing
114-
_promotefill(::AbstractGBArray{<:Any, Nothing}, y, op) = nothing
115-
_promotefill(x, ::AbstractGBArray{<:Any, Nothing}, op) = nothing
116113
_promotefill(::AbstractGBArray{<:Any, Missing}, ::AbstractGBArray{<:Any, Missing}, op) = missing
117-
_promotefill(::AbstractGBArray{<:Any, Missing}, y, op) = nothing
118-
_promotefill(x, ::AbstractGBArray{<:Any, Missing}, op) = nothing
119-
_promotefill(::AbstractGBArray{<:Any, Nothing}, ::AbstractGBArray{<:Any, Missing}, op) = nothing
120-
_promotefill(::AbstractGBArray{<:Any, Missing}, ::AbstractGBArray{<:Any, Nothing}, op) = nothing
121-
_promotefill(::AbstractGBArray{<:Any, Nothing}, ::AbstractGBArray{<:Any, <:Any}, op) = nothing
122-
_promotefill(::AbstractGBArray{<:Any, <:Any}, ::AbstractGBArray{<:Any, Nothing}, op) = nothing
114+
_promotefill(::AbstractGBArray{<:Any, Missing}, y, op) = missing
115+
_promotefill(x, ::AbstractGBArray{<:Any, Missing}, op) = missing
123116
_promotefill(::AbstractGBArray{<:Any, Missing}, ::AbstractGBArray{<:Any, <:Any}, op) = missing
124117
_promotefill(::AbstractGBArray{<:Any, <:Any}, ::AbstractGBArray{<:Any, Missing}, op) = missing
125118

src/operations/transpose.jl

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -67,10 +67,6 @@ end
6767
#This is ok per the GraphBLAS Slack channel. Should change its effect on Complex input.
6868
LinearAlgebra.adjoint(A::GBVecOrMat) = transpose(A)
6969

70-
#arrrrgh, type piracy.
71-
# TODO: avoid this if possible
72-
LinearAlgebra.transpose(::Nothing) = nothing
73-
7470
Base.unsafe_convert(::Type{Ptr{T}}, A::LinearAlgebra.AdjOrTrans{<:Any, <:AbstractGBArray}) where {T} =
7571
throw(ArgumentError("Cannot convert $(typeof(A)) directly to a pointer. Please use copy."))
7672

0 commit comments

Comments
 (0)