Skip to content

Commit 05a7875

Browse files
mcabbottdevmotion
andauthored
Allow ForwardDiff v1 (#1957)
* Allow ForwardDiff v1 * Update tests * Don't update version number --------- Co-authored-by: David Widmann <[email protected]>
1 parent b348b5b commit 05a7875

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ DensityInterface = "0.4"
4040
Distributed = "<0.0.1, 1"
4141
FillArrays = "0.9, 0.10, 0.11, 0.12, 0.13, 1"
4242
FiniteDifferences = "0.12"
43-
ForwardDiff = "0.10"
43+
ForwardDiff = "0.10, 1"
4444
JSON = "0.21"
4545
LinearAlgebra = "<0.0.1, 1"
4646
OffsetArrays = "1"

test/univariate/discrete/negativebinomial.jl

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,10 @@ end
7676

7777
@testset "issue #1582" begin
7878
dp = mydiffp(1.0, 1.0, 0.0)
79-
@test ForwardDiff.derivative(p -> logpdf(NegativeBinomial(1.0, p), 0.0), 1.0) == dp == 1.0
79+
@test dp == 1
80+
@test ForwardDiff.derivative(p -> logpdf(NegativeBinomial(1.0, p; check_args=false), 0.0), 1.0) == dp
8081

8182
dr = mydiffr(1.0, 1.0, 0.0)
82-
@test ForwardDiff.derivative(r -> logpdf(NegativeBinomial(r, 1.0), 0.0), 1.0) == dr == 0.0
83+
@test dr == 0
84+
@test ForwardDiff.derivative(r -> logpdf(NegativeBinomial(r, 1.0), 0.0), 1.0) == dr
8385
end

0 commit comments

Comments
 (0)