Skip to content

Commit 183c94a

Browse files
authored
Check BLAS vendor, fix test warning, rephrase warn (#428)
1 parent 0bf61a2 commit 183c94a

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

src/generalizedlinearmixedmodel.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -352,7 +352,7 @@ function GeneralizedLinearMixedModel(
352352
if !any(isa(d, dist) for dist in (Bernoulli, Binomial, Poisson))
353353
@warn """Results for families with a dispersion parameter are not reliable.
354354
It is best to avoid trying to fit such models in MixedModels until
355-
the authors get a better understanding of those cases."""
355+
the authors gain a better understanding of those cases."""
356356
end
357357

358358
LMM = LinearMixedModel(f, tbl, contrasts = contrasts; wts = wts)

test/runtests.jl

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,10 @@ import LinearAlgebra: BLAS
44

55
# there seem to be processor-specific issues and knowing this is helpful
66
println(versioninfo())
7-
println(BLAS.openblas_get_config())
7+
@show BLAS.vendor()
8+
if BLAS.vendor() == :openblas
9+
println(BLAS.openblas_get_config())
10+
end
811

912
include("utilities.jl")
1013
include("pivot.jl")

test/utilities.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ using Test
66

77
using MixedModels: allequal, average, densify, dataset
88

9-
const io = IOBuffer()
109
include("modelcache.jl")
1110

1211
@testset "average" begin
@@ -60,6 +59,7 @@ end
6059
end
6160

6261
@testset "PCA" begin
62+
io = IOBuffer()
6363
pca = models(:kb07)[3].PCA.item
6464

6565
show(io, pca, covcor=true, loadings=false)

0 commit comments

Comments
 (0)