fix value-preserving zerocorr! (#275)

palday · web-flow · commit df8f0f818733 · 2020-02-20T10:13:05.000+01:00
diff --git a/src/remat.jl b/src/remat.jl
@@ -554,8 +554,8 @@ vsize(A::ReMat{T,S}) where {T,S} = S
 
 function zerocorr!(A::ReMat{T}) where {T}
     λ = A.λ
-    A.inds = intersect(A.inds, diagind(λ))
     # zero out all entries not on the diagonal
     λ[setdiff(A.inds, diagind(λ))] .= 0
+    A.inds = intersect(A.inds, diagind(λ))
     A
 end

Original file line number	Diff line number	Diff line change
`@@ -554,8 +554,8 @@ vsize(A::ReMat{T,S}) where {T,S} = S`
`554`	`554`
`555`	`555`	`function zerocorr!(A::ReMat{T}) where {T}`
`556`	`556`	`λ = A.λ`
`557`		`- A.inds = intersect(A.inds, diagind(λ))`
`558`	`557`	`# zero out all entries not on the diagonal`
`559`	`558`	`λ[setdiff(A.inds, diagind(λ))] .= 0`
	`559`	`+ A.inds = intersect(A.inds, diagind(λ))`
`560`	`560`	`A`
`561`	`561`	`end`