Merge pull request #123 from devmotion/patch-1

Add defaults for `isposdef` and `ishermitian`

Author: andreasnoack

src/generics.jl

@@ -2,9 +2,6 @@
 
 ## Basic functions
 
-Base.eltype(a::AbstractPDMat{T}) where {T<:Real} = T
-Base.eltype(::Type{AbstractPDMat{T}}) where {T<:Real} = T
-Base.ndims(a::AbstractPDMat) = 2
 Base.size(a::AbstractPDMat) = (dim(a), dim(a))
 Base.size(a::AbstractPDMat, i::Integer) = 1 <= i <= 2 ? dim(a) : 1
 Base.length(a::AbstractPDMat) = abs2(dim(a))
@@ -27,6 +24,9 @@ pdadd(a::Matrix{T}, b::AbstractPDMat{S}) where {T<:Real, S<:Real} = pdadd!(simil
 /(a::AbstractPDMat, c::T) where {T<:Real} = a * inv(c)
 Base.kron(A::AbstractPDMat, B::AbstractPDMat) = PDMat(kron(Matrix(A), Matrix(B)))
 
+# LinearAlgebra
+LinearAlgebra.isposdef(::AbstractPDMat) = true
+LinearAlgebra.ishermitian(::AbstractPDMat) = true
 
 ## whiten and unwhiten
 whiten!(a::AbstractPDMat, x::StridedVecOrMat) = whiten!(x, a, x)

test/generics.jl

@@ -23,3 +23,8 @@ using Test
         @test Matrix(pmats[i] * 3) == Matrix(pmatsa[i])
     end
 end
+
+# issue #121
+@test isposdef(PDMat([1.0 0.0; 0.0 1.0]))
+@test isposdef(PDiagMat([1.0, 1.0]))
+@test isposdef(ScalMat(2, 3.0))

test/testutils.jl

@@ -78,11 +78,17 @@ function pdtest_basics(C::AbstractPDMat, Cmat::Matrix, d::Int, verbose::Int)
 
     _pdt(verbose, "eltype")
     @test eltype(C) == eltype(Cmat)
-    #    @test eltype(typeof(C)) == eltype(typeof(Cmat))
+#    @test eltype(typeof(C)) == eltype(typeof(Cmat))
 
     _pdt(verbose, "index")
     @test all(C[i] == Cmat[i] for i in 1:(d^2))
     @test all(C[i, j] == Cmat[i, j] for j in 1:d, i in 1:d)
+
+    _pdt(verbose, "isposdef")
+    @test isposdef(C)
+
+    _pdt(verbose, "ishermitian")
+    @test ishermitian(C)
 end